Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to free result after stream closed #528

Merged
merged 1 commit into from
Mar 8, 2024
Merged

allow to free result after stream closed #528

merged 1 commit into from
Mar 8, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Mar 8, 2024

It looks like PDOStatement::closeCursor() doesn't really work in postgres, but is released via the garbage collector.

Our stream deletes all references after close so that the garbage collector can work.

fix pipeline for #526

@DavidBadura DavidBadura added the bug Something isn't working label Mar 8, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Hello 👋

here is the most recent benchmark result:

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 161.391ms (±0.00%) | 163.442ms (±0.00%) | 38.652mb        | 38.646mb   |
| benchLoad10000Events ()                | 513.900μs (±0.00%) | 527.900μs (±0.00%) | 38.652mb        | 38.646mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 159.044ms (±0.00%) | 157.291ms (±0.00%) | 38.655mb        | 38.649mb   |
| benchSave1Event ()                     | 930.300μs (±0.00%) | 998.800μs (±0.00%) | 38.655mb        | 38.649mb   |
| benchSave10000Events ()                | 474.299ms (±0.00%) | 493.616ms (±0.00%) | 38.921mb        | 38.916mb   |
| benchSave10000Aggregates ()            | 9.817s (±0.00%)    | 9.630s (±0.00%)    | 38.655mb        | 38.649mb   |
| benchSave10000AggregatesTransaction () | 7.440s (±0.00%)    | 7.519s (±0.00%)    | 38.655mb        | 38.649mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.563ms (±0.00%)   | 5.597ms (±0.00%)   | 42.520mb        | 42.514mb   |
| benchSave10000Events () | 631.875ms (±0.00%) | 662.200ms (±0.00%) | 42.797mb        | 42.792mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

ProjectionistBench
==================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.255s (±0.00%) | 3.297s (±0.00%) | 39.054mb        | 39.049mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura requested a review from DanielBadura March 8, 2024 14:08
@DavidBadura DavidBadura merged commit 6886ad6 into 3.0.x Mar 8, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the free-stream branch March 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants