Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename projection into subscription #526

Merged
merged 1 commit into from
Mar 8, 2024
Merged

rename projection into subscription #526

merged 1 commit into from
Mar 8, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Mar 8, 2024 •
edited
Loading

fix #513

@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Mar 8, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 8, 2024
@DavidBadura DavidBadura force-pushed the rename-projection-into-subscription branch 4 times, most recently from b25929e to c1c4816 Compare March 8, 2024 11:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 158.317ms (±0.00%) | 160.628ms (±0.00%) | 38.645mb        | 38.652mb   |
| benchLoad10000Events ()                | 507.800μs (±0.00%) | 511.600μs (±0.00%) | 38.645mb        | 38.652mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 160.657ms (±0.00%) | 159.197ms (±0.00%) | 38.648mb        | 38.655mb   |
| benchSave1Event ()                     | 890.600μs (±0.00%) | 954.500μs (±0.00%) | 38.648mb        | 38.655mb   |
| benchSave10000Events ()                | 481.920ms (±0.00%) | 493.230ms (±0.00%) | 38.915mb        | 38.921mb   |
| benchSave10000Aggregates ()            | 9.988s (±0.00%)    | 10.467s (±0.00%)   | 38.648mb        | 38.655mb   |
| benchSave10000AggregatesTransaction () | 7.397s (±0.00%)    | 7.399s (±0.00%)    | 38.648mb        | 38.655mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+
|                           | time (kde mode) | memory          |
+---------------------------+-----------------+-----------------+
| subject                   | Tag: <current>  | Tag: <current>  |
+---------------------------+-----------------+-----------------+
| benchHandle10000Events () | 3.273s (±0.00%) | 39.047mb        |
+---------------------------+-----------------+-----------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.407ms (±0.00%)   | 5.561ms (±0.00%)   | 42.513mb        | 42.520mb   |
| benchSave10000Events () | 636.079ms (±0.00%) | 643.865ms (±0.00%) | 42.791mb        | 42.797mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

ProjectionistBench
==================

+---------------------------+-----------------+------------+
|                           | time (kde mode) | memory     |
+---------------------------+-----------------+------------+
| subject                   | Tag: base       | Tag: base  |
+---------------------------+-----------------+------------+
| benchHandle10000Events () | 3.283s (±0.00%) | 39.054mb   |
+---------------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the rename-projection-into-subscription branch from c1c4816 to c380cef Compare March 8, 2024 11:53
@DavidBadura DavidBadura marked this pull request as ready for review March 8, 2024 11:53
@DavidBadura DavidBadura requested a review from DanielBadura March 8, 2024 11:54
@DavidBadura DavidBadura force-pushed the rename-projection-into-subscription branch from c380cef to 2e9cc2b Compare March 8, 2024 12:00
@DavidBadura DavidBadura mentioned this pull request Mar 8, 2024
Merged
@DavidBadura DavidBadura force-pushed the rename-projection-into-subscription branch from 2e9cc2b to 23fc743 Compare March 8, 2024 14:17
@DavidBadura DavidBadura linked an issue Mar 8, 2024 that may be closed by this pull request
rename projectionist / projection engine #513
Closed
DanielBadura
DanielBadura approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still use projections and processors in the docs for clarificaiton. But this is fine for now i think 👍

@DavidBadura DavidBadura merged commit 29833b0 into 3.0.x Mar 8, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the rename-projection-into-subscription branch March 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

rename projectionist / projection engine
2 participants
@DavidBadura @DanielBadura