Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release preparation for v0.17.0 #434

Merged
merged 10 commits into from
Feb 4, 2022
Merged

Release preparation for v0.17.0 #434

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ac67e1b
lib: Export `GenericError` to avoid linking to private items
lexnv Feb 4, 2022
d143ec4
Bump version to v0.17.0
lexnv Feb 4, 2022
cc3af9e
doc: Add crates to bump
lexnv Feb 4, 2022
f474063
Update changelog
lexnv Feb 4, 2022
82b689b
changelog: Add new line between title and list
lexnv Feb 4, 2022
80af19c
releasing: Remove extra closing bracket
lexnv Feb 4, 2022
090f7f9
releasing: Fix cargo install typo for cargo-hack
lexnv Feb 4, 2022
bcbb82b
Remove subxt version from macro and test-runtime
lexnv Feb 4, 2022
cfcb30a
releasing: Change PR link to sort in descending order
lexnv Feb 4, 2022
1fb222f
changelog: Add missing PR
lexnv Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.17.0] - 2022-02-04

### Added
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: there's some inconsistency over "do we have a newline between the title and list" in this doc; let's add a newline here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in the latest revision


- Get event context on EventSubscription ([#423](https://github.com/paritytech/subxt/pull/423))

### Changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the jsonrpsee change missing from here or excluded from the release?

Copy link
Collaborator

@jsdw jsdw Feb 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch!

The default sort order of PRs is annoying; perhaps it's worth noting in the release doc to filter by is:pr sort:updated-desc is:closed to see PRs in order of when they were updated.

Everything else looks good I think; just that one that's missing because it's a fairly old PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yupp, makes sense


- Add more tests for events.rs/decode_and_consume_type ([#430](https://github.com/paritytech/subxt/pull/430))
- Update substrate dependencies ([#429](https://github.com/paritytech/subxt/pull/429))
- export RuntimeError struct ([#427](https://github.com/paritytech/subxt/pull/427))
- remove unused PalletError struct ([#425](https://github.com/paritytech/subxt/pull/425))
- Move Subxt crate into a subfolder ([#424](https://github.com/paritytech/subxt/pull/424))
- Add release checklist ([#418](https://github.com/paritytech/subxt/pull/418))

## [0.16.0] - 2022-02-01

*Note*: This is a significant release which introduces support for V14 metadata and macro based codegen, as well as making many breaking changes to the API.
Expand Down
8 changes: 4 additions & 4 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ We also assume that ongoing work done is being merged directly to the `master` b

If there are minor issues with the documentation, they can be fixed in the release branch.

4. Bump the crate version in `Cargo.toml` to whatever was decided in step 2 for `subxt-codegen`, `subxt-macro`, `subxt` and `subxt-cli`.
4. Bump the crate version in `Cargo.toml` to whatever was decided in step 2 for `subxt-cli`, `subxt-codegen`, `subxt-examples`, `subxt-macro` ,`subxt`, `test-runtime`.

5. Update `CHANGELOG.md` to reflect the difference between this release and the last. If you're unsure of
what to add, check with the Tools team. See the `CHANGELOG.md` file for details of the format it follows.
Expand All @@ -46,8 +46,8 @@ We also assume that ongoing work done is being merged directly to the `master` b
Additionally, `subxt-macro` has a circular dev dependency on `subxt`, so we use `cargo hack` to remove
dev dependencies (and `--allow-dirty` to ignore the git changes as a result) to publish it.

So, first install `cargo hack` with `cargo install cargo hack`. Next, you can run something like the following
command to publish each crate in the required order (allowing a little time inbetween each to let `crates.io` catch up)
So, first install [cargo-hack](https://docs.rs/crate/cargo-hack/latest) with `cargo install cargo-hack`. Next, you can run something like the following
command to publish each crate in the required order (allowing a little time in between each to let `crates.io` catch up
with what we've published).

```
Expand All @@ -73,4 +73,4 @@ We also assume that ongoing work done is being merged directly to the `master` b

Once this is pushed, go along to [the releases page on GitHub](https://github.com/paritytech/subxt/releases)
and draft a new release which points to the tag you just pushed to `master` above. Copy the changelog comments
for the current release into the release description.
for the current release into the release description.
4 changes: 2 additions & 2 deletions cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subxt-cli"
version = "0.16.0"
version = "0.17.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"

Expand All @@ -16,7 +16,7 @@ path = "src/main.rs"

[dependencies]
# perform subxt codegen
subxt-codegen = { version = "0.16.0", path = "../codegen" }
subxt-codegen = { version = "0.17.0", path = "../codegen" }
# parse command line args
structopt = "0.3.25"
# make the request to a substrate node to get the metadata
Expand Down
2 changes: 1 addition & 1 deletion codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subxt-codegen"
version = "0.16.0"
version = "0.17.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subxt-examples"
version = "0.16.0"
version = "0.17.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"
publish = false
Expand Down
6 changes: 3 additions & 3 deletions macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subxt-macro"
version = "0.16.0"
version = "0.17.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"
autotests = false
Expand All @@ -27,10 +27,10 @@ quote = "1.0.8"
syn = "1.0.58"
scale-info = "1.0.0"

subxt-codegen = { path = "../codegen", version = "0.16.0" }
subxt-codegen = { path = "../codegen", version = "0.17.0" }

[dev-dependencies]
pretty_assertions = "1.0.0"
subxt = { path = "../subxt", version = "0.16.0" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove version from this; if I read it right, doing so may mean we no logner need to use cargo hack to publish this crate as cargo publish will strip the dependency automatically!

subxt = { path = "../subxt" }
trybuild = "1.0.38"
sp-keyring = "5.0.0"
4 changes: 2 additions & 2 deletions subxt/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "subxt"
version = "0.16.0"
version = "0.17.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"

Expand All @@ -27,7 +27,7 @@ serde = { version = "1.0.124", features = ["derive"] }
serde_json = "1.0.64"
thiserror = "1.0.24"

subxt-macro = { version = "0.16.0", path = "../macro" }
subxt-macro = { version = "0.17.0", path = "../macro" }

sp-core = { version = "5.0.0", default-features = false }
sp-runtime = { version = "5.0.0", default-features = false }
Expand Down
1 change: 1 addition & 0 deletions subxt/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ pub use crate::{
error::{
BasicError,
Error,
GenericError,
RuntimeError,
TransactionError,
},
Expand Down
4 changes: 2 additions & 2 deletions test-runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "test-runtime"
version = "0.16.0"
version = "0.17.0"
edition = "2021"

[dependencies]
Expand All @@ -9,7 +9,7 @@ sp-runtime = "5.0.0"
codec = { package = "parity-scale-codec", version = "2", default-features = false, features = ["derive", "full", "bit-vec"] }

[build-dependencies]
subxt = { path = "../subxt", version = "0.16.0" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the version entirely from this to save us a little future trouble.

subxt = { path = "../subxt" }
sp-core = "5.0.0"
async-std = { version = "1.9.0", features = ["attributes", "tokio1"] }
which = "4.2.2"