-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparation for v0.17.0 #434
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@@ -6,6 +6,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
## [0.17.0] - 2022-02-04 | |||
|
|||
### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: there's some inconsistency over "do we have a newline between the title and list" in this doc; let's add a newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in the latest revision
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@@ -9,7 +9,7 @@ sp-runtime = "5.0.0" | |||
codec = { package = "parity-scale-codec", version = "2", default-features = false, features = ["derive", "full", "bit-vec"] } | |||
|
|||
[build-dependencies] | |||
subxt = { path = "../subxt", version = "0.16.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the version
entirely from this to save us a little future trouble.
Signed-off-by: Alexandru Vasile <[email protected]>
|
||
[dev-dependencies] | ||
pretty_assertions = "1.0.0" | ||
subxt = { path = "../subxt", version = "0.16.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove version
from this; if I read it right, doing so may mean we no logner need to use cargo hack
to publish this crate as cargo publish
will strip the dependency automatically!
Signed-off-by: Alexandru Vasile <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
|
||
- Get event context on EventSubscription ([#423](https://github.com/paritytech/subxt/pull/423)) | ||
|
||
### Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the jsonrpsee change missing from here or excluded from the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch!
The default sort order of PRs is annoying; perhaps it's worth noting in the release doc to filter by is:pr sort:updated-desc is:closed
to see PRs in order of when they were updated.
Everything else looks good I think; just that one that's missing because it's a fairly old PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yupp, makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question about the CHANGELOG
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
* lib: Export `GenericError` to avoid linking to private items Signed-off-by: Alexandru Vasile <[email protected]> * Bump version to v0.17.0 Signed-off-by: Alexandru Vasile <[email protected]> * doc: Add crates to bump Signed-off-by: Alexandru Vasile <[email protected]> * Update changelog Signed-off-by: Alexandru Vasile <[email protected]> * changelog: Add new line between title and list Signed-off-by: Alexandru Vasile <[email protected]> * releasing: Remove extra closing bracket Signed-off-by: Alexandru Vasile <[email protected]> * releasing: Fix cargo install typo for cargo-hack Signed-off-by: Alexandru Vasile <[email protected]> * Remove subxt version from macro and test-runtime Signed-off-by: Alexandru Vasile <[email protected]> * releasing: Change PR link to sort in descending order Signed-off-by: Alexandru Vasile <[email protected]> * changelog: Add missing PR Signed-off-by: Alexandru Vasile <[email protected]>
Release preparation for v0.17.0