Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Kademlia is in fact unidirectional #901

Closed
tomaka opened this issue Oct 11, 2018 · 2 comments · Fixed by #1386
Closed

Kademlia is in fact unidirectional #901

tomaka opened this issue Oct 11, 2018 · 2 comments · Fixed by #1386
Labels
I3-bug The node fails to follow expected behavior.
Milestone
Polkadot

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 11, 2018

There was a misunderstanding of the libp2p specs. Kademlia is in fact unidirectional, meaning that if nodes A and B want to query each other they each have to open their own substream.

cc libp2p/rust-libp2p#557

The change can be done either in a backwards compatible way (ie. accept incorrect remotes but do it correctly) or in a breaking way.
@tomaka tomaka added the M4-core label Oct 11, 2018
@tomaka tomaka added this to the 1.0 (final) milestone Oct 11, 2018
@gavofyork gavofyork added the I3-bug The node fails to follow expected behavior. label Dec 18, 2018
@gavofyork gavofyork modified the milestones: 1.0 (final), 1.x series Dec 18, 2018
@gavofyork
Copy link
Member

@tomaka is this still relevant?

@tomaka
Copy link
Contributor Author

tomaka commented Dec 18, 2018

This has been fixed in upstream libp2p. I've been working on updating Substrate for the latest version.

@tomaka tomaka mentioned this issue Jan 10, 2019
Merged
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gavofyork
Remove CC3 designation (paritytech#901)
c6de22a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Milestone
Polkadot
Development

Successfully merging a pull request may close this issue.

Update to latest libp2p tomaka/polkadot
2 participants
@gavofyork @tomaka