Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kademlia is in fact unidirectional #557

Closed
tomaka opened this issue Oct 11, 2018 · 2 comments
Closed

Kademlia is in fact unidirectional #557

tomaka opened this issue Oct 11, 2018 · 2 comments
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Oct 11, 2018

If nodes A and B want to query each other, they each have to open their own substream.
This makes it possible to improve the API and code of Kademlia.
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:moderate labels Oct 11, 2018
@tomaka tomaka mentioned this issue Oct 11, 2018
Closed
@tomaka tomaka assigned tomaka and unassigned tomaka Oct 11, 2018
@tomaka
Copy link
Member Author

tomaka commented Oct 11, 2018

Unassigned myself because I'm not going to work on this immediately, but this is blocked by the ongoing rework.

@tomaka
Copy link
Member Author

tomaka commented Nov 29, 2018

Done in #580

@tomaka tomaka closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka