Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow issue #184

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix stack overflow issue #184

wants to merge 4 commits into from

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Jan 30, 2025

Fixes: #177
Default stack size is 64KB which is not enough for our use cases

@smiasojed smiasojed marked this pull request as ready for review January 30, 2025 11:56
@smiasojed smiasojed marked this pull request as draft January 30, 2025 12:02
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

You got any insights on the stack size? We just might give it some more margin. Can we add a second fixture with multiple different contract instantiations?

@smiasojed
Copy link
Collaborator Author

smiasojed commented Jan 30, 2025

Nice catch!

You got any insights on the stack size? We just might give it some more margin. Can we add a second fixture with multiple different contract instantiations?

I enabled heap and stack checks and allocations logging to see the issue root cause.
what sort of test would you like to have

C1 -> new C2() -> new C3() -> new C4() -> new C5()
or
contract C
{
  constructor() {
    new C1();
    new C2();
    new C3();
    new C4();
    new C5();
  }
}

@xermicus
Copy link
Member

what sort of test would you like to have

Can you add both? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revive JS version fails when compiling contract which instantiate another one
2 participants