Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive JS version fails when compiling contract which instantiate another one #177

Closed
Tracked by #181
smiasojed opened this issue Jan 28, 2025 · 4 comments · Fixed by #184
Closed
Tracked by #181

Revive JS version fails when compiling contract which instantiate another one #177

smiasojed opened this issue Jan 28, 2025 · 4 comments · Fixed by #184
Assignees
@smiasojed

Comments

@smiasojed
Copy link
Collaborator

smiasojed commented Jan 28, 2025 •
edited
Loading

Contract:

// SPDX-License-Identifier: GPL-3.0

pragma solidity >=0.8.2 <0.9.0;

contract C1 {
    constructor() {
    }
}

contract C2 {
    constructor() {
        C1 newContract = new C1();
    }
}

Callstack after compiling to asm.js target:

     Error: Aborted(segmentation fault)
      at abort (examples/node/resolc.js:8848881:41)
      at segfault (examples/node/resolc.js:8848579:3)
      at $75436 (examples/node/resolc.js:8847440:4)
      at emscripten_builtin_malloc (examples/node/resolc.js:8796570:6)
      at llvm__SmallVectorBase_unsigned_20int___grow_pod_28void__2c_20unsigned_20long_2c_20unsigned_20long_29 (examples/node/resolc.js:1608844:13)
      at $28anonymous_20namespace_29__DAGCombiner__visitTokenFactor_28llvm__SDNode__29 (examples/node/resolc.js:4496984:17)
      at $28anonymous_20namespace_29__DAGCombiner__combine_28llvm__SDNode__29 (examples/node/resolc.js:4421389:10)
      at llvm__SelectionDAG__Combine_28llvm__CombineLevel_2c_20llvm__AAResults__2c_20llvm__CodeGenOptLevel_29 (examples/node/resolc.js:4420692:16)
      at llvm__SelectionDAGISel__CodeGenAndEmitDAG_28_29 (examples/node/resolc.js:4962737:6)
      at llvm__SelectionDAGISel__SelectBasicBlock_28llvm__ilist_iterator_w_bits_llvm__ilist_detail__node_options_llvm__Instruction_2c_20true_2c_20false_2c_20void_2c_20true__2c_20false_2c_20true__2c_20llvm__ilist_iterator_w_bits_llvm__ilist_detail__node_options_llvm__Instruction_2c_20true_2c_20false_2c_20void_2c_20true__2c_20false_2c_20true__2c_20bool__29 (examples/node/resolc.js:4964258:6)
      at llvm__SelectionDAGISel__SelectAllBasicBlocks_28llvm__Function_20const__29 (examples/node/resolc.js:4961395:22)
      at llvm__SelectionDAGISel__runOnMachineFunction_28llvm__MachineFunction__29 (examples/node/resolc.js:4958283:35)
      at Array.llvm__RISCVDAGToDAGISel__runOnMachineFunction_28llvm__MachineFunction__29 (examples/node/resolc.js:2556740:10)
      at Array.llvm__MachineFunctionPass__runOnFunction_28llvm__Function__29 (examples/node/resolc.js:5330169:60)
      at llvm__FPPassManager__runOnFunction_28llvm__Function__29 (examples/node/resolc.js:2046464:63)
      at Array.llvm__FPPassManager__runOnModule_28llvm__Module__29 (examples/node/resolc.js:2054129:11)
      at llvm__legacy__PassManagerImpl__run_28llvm__Module__29 (examples/node/resolc.js:2048632:67)
      at llvm__legacy__PassManager__run_28llvm__Module__29 (examples/node/resolc.js:2054276:10)
      at LLVMTargetMachineEmit_28LLVMOpaqueTargetMachine__2c_20LLVMOpaqueModule__2c_20llvm__raw_pwrite_stream__2c_20LLVMCodeGenFileType_2c_20char___29 (examples/node/resolc.js:8656291:5)
      at LLVMTargetMachineEmitToMemoryBuffer (examples/node/resolc.js:8656326:8)
      at inkwell__targets__TargetMachine__write_to_memory_buffer__h7231b236ed3dfba9 (examples/node/resolc.js:8665002:10)
      at revive_llvm_context__target_machine__TargetMachine__write_to_memory_buffer__h426c9cd21a47cc1c (examples/node/resolc.js:682930:3)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at revive_llvm_context__polkavm__context__Context$LT$D$GT$__build__hda361ca43db3c114 (examples/node/resolc.js:453304:41)
      at invoke_viiiii (examples/node/resolc.js:8854085:29)
      at revive_solidity__project__contract__Contract__compile__h472f314cdd825900 (examples/node/resolc.js:381491:43)
      at invoke_viiiiii (examples/node/resolc.js:8854030:29)
      at _$LT$revive_solidity__project__Project$u20$as$u20$revive_llvm_context__polkavm__Dependency$GT$__compile__h944896e7817da2be (examples/node/resolc.js:414414:12)
      at revive_llvm_context__polkavm__context__Context$LT$D$GT$__compile_dependency__hd0470d6bdac12401 (examples/node/resolc.js:451470:4)
      at invoke_viiii (examples/node/resolc.js:8854041:29)
      at revive_llvm_context__polkavm__evm__create__contract_hash__h3f5c8635d5fbbbc7 (examples/node/resolc.js:285889:16)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at revive_solidity__yul__parser__statement__expression__function_call__FunctionCall__into_llvm__h55a527f53a81382f (examples/node/resolc.js:278911:70)
      at revive_solidity__yul__parser__statement__expression__Expression__into_llvm__hb6df05caeb8f2c88 (examples/node/resolc.js:241619:29)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at revive_solidity__yul__parser__statement__expression__function_call__FunctionCall__pop_arguments_llvm__h011eb1bb44ecdfe7 (examples/node/resolc.js:280634:17)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at revive_solidity__yul__parser__statement__expression__function_call__FunctionCall__into_llvm__h55a527f53a81382f (examples/node/resolc.js:278824:69)
      at revive_solidity__yul__parser__statement__expression__Expression__into_llvm__hb6df05caeb8f2c88 (examples/node/resolc.js:241619:29)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at _$LT$revive_solidity__yul__parser__statement__block__Block$u20$as$u20$revive_llvm_context__polkavm__WriteLLVM$LT$D$GT$$GT$__into_llvm__h5bd44d3d69f7e2d1 (examples/node/resolc.js:351534:49)
      at invoke_iii (examples/node/resolc.js:8853986:36)
      at _$LT$revive_solidity__yul__parser__statement__block__Block$u20$as$u20$revive_llvm_context__polkavm__WriteLLVM$LT$D$GT$$GT$__into_llvm__h5bd44d3d69f7e2d1 (examples/node/resolc.js:351515:54)
      at _$LT$revive_llvm_context__polkavm__context__function__runtime__deploy_code__DeployCode$LT$B$C$D$GT$$u20$as$u20$revive_llvm_context__polkavm__WriteLLVM$LT$D$GT$$GT$__into_llvm__hea20f087af89bac7 (examples/node/resolc.js:328617:25)
      at invoke_iii (examples/node/resolc.js:8853986:36)
      at _$LT$revive_solidity__yul__parser__statement__object__Object$u20$as$u20$revive_llvm_context__polkavm__WriteLLVM$LT$D$GT$$GT$__into_llvm__h4569284e2e7f6209 (examples/node/resolc.js:330194:18)
      at invoke_iii (examples/node/resolc.js:8853986:36)
      at _$LT$revive_solidity__project__contract__ir__IR$u20$as$u20$revive_llvm_context__polkavm__WriteLLVM$LT$D$GT$$GT$__into_llvm__hfd6c83b15a10c533 (examples/node/resolc.js:437975:11)
      at invoke_iii (examples/node/resolc.js:8853986:36)
      at revive_solidity__project__contract__Contract__compile__h472f314cdd825900 (examples/node/resolc.js:381423:48)
      at invoke_viiiiii (examples/node/resolc.js:8854030:29)
      at revive_solidity__process__Process__run__h7b81d7c5fb86a99f (examples/node/resolc.js:114021:19)
      at invoke_ii (examples/node/resolc.js:8854008:36)
      at Array.resolc__main__he11aae0b1b6117c4 (examples/node/resolc.js:131391:32)
      at std__sys__backtrace____rust_begin_short_backtrace__hd0dd3890679d5a28 (examples/node/resolc.js:190562:25)
      at std__rt__lang_start___$u7b$$u7b$closure$u7d$$u7d$__h609630a6b1a0db34_20_28_llvm_11126190848252339740_29 (examples/node/resolc.js:113665:3)
      at invoke_ii (examples/node/resolc.js:8854008:36)
      at std__rt__lang_start_internal__h5025c7fc70b7fd4f (examples/node/resolc.js:8744210:12)
      at main (examples/node/resolc.js:133136:8)
      at /Users/smiasojed/Development/revive-new/js/examples/node/resolc.js:8848914:12
      at Object.callMain (examples/node/resolc.js:8854748:15)
      at _resolc_compile (examples/node/resolc.js:8853161:25)
      at _$LT$revive_solidity__process__worker_process__WorkerProcess$u20$as$u20$revive_solidity__process__Process$GT$__call__h3034624cad96de86 (examples/node/resolc.js:352794:13)
      at invoke_vii (examples/node/resolc.js:8853964:29)
      at core__ops__function__impls___$LT$impl$u20$core__ops__function__FnOnce$LT$A$GT$$u20$for$u20$$RF$mut$u20$F$GT$__call_once__h8235e203eaf8fc66 (examples/node/resolc.js:353478:12)
      at invoke_viii (examples/node/resolc.js:8853997:29)
      at _$LT$alloc__vec__Vec$LT$T$GT$$u20$as$u20$alloc__vec__spec_from_iter__SpecFromIter$LT$T$C$I$GT$$GT$__from_iter__h8ff164b254d957ae (examples/node/resolc.js:298545:16)
      at _$LT$alloc__collections__btree__map__BTreeMap$LT$K$C$V$GT$$u20$as$u20$core__iter__traits__collect__FromIterator$LT$$LP$K$C$V$RP$$GT$$GT$__from_iter__hac07e6fcf26c066a (examples/node/resolc.js:426945:3)
      at invoke_vii (examples/node/resolc.js:8853964:29)
      at revive_solidity__project__Project__compile__h3e1af1234c452c1a (examples/node/resolc.js:411928:26)
      at invoke_viiiii (examples/node/resolc.js:8854085:29)
      at revive_solidity__standard_json__hae73c2bbd0daa48a (examples/node/resolc.js:60133:35)
      at invoke_iiiiiiii (examples/node/resolc.js:8854140:36)
      at Array.resolc__main__he11aae0b1b6117c4 (examples/node/resolc.js:131796:39)
      at std__sys__backtrace____rust_begin_short_backtrace__hd0dd3890679d5a28 (examples/node/resolc.js:190562:25)
      at std__rt__lang_start___$u7b$$u7b$closure$u7d$$u7d$__h609630a6b1a0db34_20_28_llvm_11126190848252339740_29 (examples/node/resolc.js:113665:3)
      at invoke_ii (examples/node/resolc.js:8854008:36)
      at std__rt__lang_start_internal__h5025c7fc70b7fd4f (examples/node/resolc.js:8744210:12)
      at main (examples/node/resolc.js:133136:8)
      at /Users/smiasojed/Development/revive-new/js/examples/node/resolc.js:8848914:12
      at Object.callMain (examples/node/resolc.js:8854748:15)
      at compile (examples/node/revive.js:17:12)
      at Context.<anonymous> (file:///Users/smiasojed/Development/revive-new/js/tests/node.test.mjs:92:26)
      at process.processImmediate (node:internal/timers:483:21)
@smiasojed smiasojed self-assigned this Jan 28, 2025
@xermicus
Copy link
Member

Without digging into it, is it OOM?

@smiasojed
Copy link
Collaborator Author

smiasojed commented Jan 28, 2025 •
edited
Loading

I am not sure, we have at abort the heap size equal to 1.7GB with mem limit 2GB. I need to check a few other things. But this does not comes from out of memory handler, which is also present in the code.

@xermicus
Copy link
Member

xermicus commented Jan 28, 2025 •
edited
Loading

HEAPU32[emscripten_get_sbrk_ptr() >> 2] < $1 + 4 >>> 0 I just found this a bit suspicious 🙂 Additionally I could imagine that the available resources are just enough to compile a single contract, but exhausts with multiple ones? Reaching the memory limit like this would indicate a refactoring: We need to cache everything and make sure only ever a single compiler instance is kept around. Anyways, I'm just guessing here.

@xermicus xermicus marked this as a duplicate of #183 Jan 30, 2025
@xermicus xermicus mentioned this issue Jan 30, 2025
Open
6 tasks
@smiasojed
Copy link
Collaborator Author

smiasojed commented Jan 30, 2025 •
edited
Loading

test.txt
YUL JSON input causing issue with revive-js
with native revive works fine
resolc --recursive-process < ./test.txt

@smiasojed smiasojed mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smiasojed smiasojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stack overflow issue paritytech/revive
2 participants
@xermicus @smiasojed