Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix clippy warnings #7625

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Fix clippy warnings #7625

merged 6 commits into from
Aug 16, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 15, 2023

(preparation for monorepo)

Turns out clippy does not run everywhere without the --workspace flag 🙃. Now adding it and fixing the warnings.

ggwpez added 6 commits August 15, 2023 15:51
@ggwpez
Fix clippy check
34571bc 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Autofix clippy
f919068 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Fix trivial
a6b0520 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
fmt
2dfac7a 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
suppress warnings
c3df4a2 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Quiet clippy 😌
356191b 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 15, 2023
@ggwpez ggwpez self-assigned this Aug 15, 2023
@ggwpez ggwpez marked this pull request as ready for review August 15, 2023 14:14
@ggwpez ggwpez requested review from chevdor and a team as code owners August 15, 2023 14:14
@paritytech-ci paritytech-ci requested a review from a team August 15, 2023 14:15
@paritytech-ci paritytech-ci requested a review from a team August 15, 2023 14:22
@alvicsam alvicsam mentioned this pull request Aug 15, 2023
Closed
chevdor
chevdor approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, you are on a good path to repell the Attack of the clone 😄

@ggwpez
Copy link
Member Author

ggwpez commented Aug 16, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 2157c2f into master Aug 16, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-fix-clippy branch August 16, 2023 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@rcny rcny rcny approved these changes

@bkchr bkchr bkchr approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggwpez @chevdor @rcny @bkchr @alvicsam