This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[DNM] Debug clippy #7624
Closed
[DNM] Debug clippy #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this goes green we may try to run |
ggwpez
reviewed
Aug 15, 2023
ggwpez
reviewed
Aug 15, 2023
scripts/ci/gitlab/pipeline/test.yml
Outdated
| - cargo version && cargo clippy --version | ||
| - SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --locked --all-targets | ||
| - SKIP_WASM_BUILD=1 cargo +1.70 clippy --all-targets --locked -p polkadot-runtime-parachains |
There was a problem hiding this comment.
Suggested change
| - SKIP_WASM_BUILD=1 cargo +1.70 clippy --all-targets --locked -p polkadot-runtime-parachains | |
| - rustup install 1.70 && SKIP_WASM_BUILD=1 cargo +1.70 clippy --all-targets --locked -p polkadot-runtime-parachains |
There was a problem hiding this comment.
Obviously this is a shitty solution, but you now can debug from here why this is not working correctly in the docker without the rustup.
|
superseded by #7625 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.