-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix compile with new compiler - dead code #4530
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -319,10 +319,12 @@ struct MonitorConfig { | |
#[derive(Debug, Clone, StructOpt)] | ||
struct EmergencySolutionConfig { | ||
/// The block hash at which scraping happens. If none is provided, the latest head is used. | ||
#[allow(dead_code)] | ||
#[structopt(long)] | ||
at: Option<Hash>, | ||
|
||
/// The solver algorithm to use. | ||
#[allow(dead_code)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if unused should be removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but this would change public API, hence we can't remove it like that without risking breakage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @kianenigma There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unless there is a decision before CI passes, let's make this a follow-up and avoid any further friction for people getting red CI tests and the goto fix There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ack, thanks for the ping @ordian. |
||
#[structopt(subcommand)] | ||
solver: Solvers, | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More stuff to remove when we get rid of the feature gate :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, ...