This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix compile with new compiler - dead code #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
A0-please_review
pepoviola
approved these changes
Dec 15, 2021
sandreim
approved these changes
Dec 15, 2021
| @@ -19,12 +19,16 @@ use polkadot_node_subsystem_util::metrics::{self, prometheus}; | |||
| #[derive(Clone)] | |||
| struct MetricsInner { | |||
| /// Number of opened disputes. | |||
| #[cfg(feature = "disputes")] | |||
There was a problem hiding this comment.
More stuff to remove when we get rid of the feature gate :P
ordian
reviewed
Dec 15, 2021
| #[structopt(long)] | ||
| at: Option<Hash>, | ||
|
|
||
| /// The solver algorithm to use. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Yes, but this would change public API, hence we can't remove it like that without risking breakage.
There was a problem hiding this comment.
Unless there is a decision before CI passes, let's make this a follow-up and avoid any further friction for people getting red CI tests and the goto fix merge master doesn't cut it :)
There was a problem hiding this comment.
ack, thanks for the ping @ordian.
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Dec 16, 2021
* master: Bump tokio from 1.14.0 to 1.15.0 (#4537) Bump mick-jaeger from 0.1.6 to 0.1.7 (#4538) Versi chainspec based on Rococo. (#4485) Bump proc-macro2 from 1.0.33 to 1.0.34 (#4526) fix compile with new compiler - dead code (#4530) introduce trusted parachain Encointer for rococo and westend (#4213) add Encointer TrustedTeleporter (#4401) Bump libc from 0.2.109 to 0.2.112 (#4522) Bump serde_json from 1.0.72 to 1.0.73 (#4523)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.