-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds redirects file #217
Adds redirects file #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions
redirects.json
Outdated
}, | ||
{ | ||
"key":"/learn/platform/roadmap/", | ||
"value":"//" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be a double-slash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! Actually no! This redirect is broken
"value":"/builders/interoperability/xcm/core-concepts/weights-fees/" | ||
}, | ||
{ | ||
"key":"/builders/xcm/xc20/index/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this needs to have /index/
even if that's not in the URL path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that is how we had it in the redirects section of the mkdocs.yml
file - So, if this was the case, these redirects were wrong all along, right?
I guess now with server-side we don't need the /index/
- /builders/xcm/xc20/
shows a 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't broken before because the redirects before were based on the file name, not the path it renders in the browser (without .md
). But anyways, ok cool good to know. Sorry I should have just tested these to confirm myself hahah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know very little about these redirects but, my pattern recognition brain doesn't see anything weird so we have that going for us.
Co-authored-by: Kevin Neilson <[email protected]>
We will be working with server-side redirects. We will need to add any new redirects in this JSON file that is automatically picked up in the build process