Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission XTokens Pallet Docs #1067

Merged
merged 15 commits into from
Jan 22, 2025
Merged

Decommission XTokens Pallet Docs #1067

merged 15 commits into from
Jan 22, 2025

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Jan 8, 2025

Description

XTokens Pallet has been deprecated and replaced by the PolkadotXCM Pallet. XTokens.sol Precompile remains, but it has been re-configured under the hood to use PolkadotXCM Pallet. This PR removes the XTokens Pallet page and re-directs users to use the PolkadotXCM Pallet wherever possible. However, some references to the XTokens Precompile are kept.

Checklist

  • I have added a label to this PR 🏷️

Corresponding PRs

Please link to any corresponding PRs here.
papermoonio/moonbeam-mkdocs#213

After Translation Requirements

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jan 8, 2025
@themacexpert themacexpert added the B0 - Needs Review Pull request is ready for review label Jan 10, 2025
@themacexpert themacexpert requested a review from eshaben January 14, 2025 17:58
@eshaben
Copy link
Contributor

eshaben commented Jan 17, 2025

Now goes with papermoonio/moonbeam-mkdocs#217

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Might be useful to do a search for all instances of PolkadotXCM and switch to Polkadot XCM, same with XTokens to be X-Tokens, and I think most instances for XCMTransaction should be XCM Transactor already, but wouldn't hurt to double-check that one either.

Watch out if it's referencing the pallet in backticks, those can remain as is, as they're generally referencing technical aspects of the pallet

builders/interoperability/mrl.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/overview.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/send-execute-xcm.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/xc20/overview.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/xc20/send-xc20s/overview.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/xc20/send-xc20s/overview.md Outdated Show resolved Hide resolved
builders/substrate/interfaces/interoperability/.pages Outdated Show resolved Hide resolved
@themacexpert themacexpert requested a review from eshaben January 17, 2025 18:32
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice, thanks!

@themacexpert themacexpert added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 21, 2025
@eshaben eshaben merged commit 0436052 into master Jan 22, 2025
1 check passed
@eshaben eshaben deleted the themacexpert/xtokensp branch January 22, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants