Enable pantsd in Travis #7440
Enable pantsd in Travis #7440
Conversation
|
Removing the Draft qualifier to trigger travis, but this is still not ready for review. |
blorente
force-pushed
the
blorente/pantsd-in-travis
branch
4 times, most recently
from
ccb8c3e to
56ecae1
Compare
tests/python/pants_test/backend/project_info/tasks/test_idea_plugin_integration.py
Outdated
Show resolved
Hide resolved
blorente
force-pushed
the
blorente/pantsd-in-travis
branch
from
d9818fb to
b4f01ff
Compare
Also enable shutdown-after-use. Add a decorator to disable pantsd in integration tests that fail under pantsd. Blacklist a few more tests (which appear to be flaky, perhaps... gulp), and mark pantsd integration tests as hermetic. Only apply pantsd on integration test shards. Blacklist some other stuff Fix test_stats_local_json_file Add more reasoning for blacklisted tests Skip some more tests Add some colour to the hermetic errors Also skip test_v2_list Hacky way of making hermetic tests run Import fixes Skip some weird interactions with the hermetic hacks Pointless Commit to trigger travis Make stuff non-hermetic Explicitly disable pantsd in the test coordinator Add some color to some of the failures
blorente
force-pushed
the
blorente/pantsd-in-travis
branch
from
b4f01ff to
c803106
Compare
blorente
force-pushed
the
blorente/pantsd-in-travis
branch
from
0c1ae1c to
0492f1b
Compare
|
I'm pretty happy with the state of this, removing the WIP tag, will blacklist more tomorrow if travis is not green. Some things to note:
|
blorente
requested review from
illicitonion,
cosmicexplorer,
Eric-Arellano,
benjyw and
stuhood
| @@ -284,6 +299,13 @@ def run_pants_with_workdir_without_waiting(self, command, workdir, config=None, | |||
| '--cache-bootstrap-read', '--cache-bootstrap-write' | |||
| ]) | |||
|
|
|||
| if self.should_configure_pantsd(): | |||
| args.append("--enable-pantsd=True") | |||
| args.append("--no-shutdown-pantsd-after-run") | |||
There was a problem hiding this comment.
I thought that our intent right now was to actually enable --shutdown-pantsd-after-run... but I think that you also determined that because of the temporary workdir, pantsd will shutdown after each run anyway?
There was a problem hiding this comment.
So we don't want to shutdown after every run inside the tests, because some of them rely on pantsd living run after run (although they don't rely on this codepath). We do want to set it (probably) in the overpants, the test coordinator, via travis env var. But this should be done at the same time as we enable pantsd by default, and shouldn't affect these changes at all.
There was a problem hiding this comment.
I would argue that those tests should be marked hermetic and explicitly set the relevant values. But this works too!
tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_cache_compile_integration.py
Outdated
Show resolved
Hide resolved
tests/python/pants_test/engine/legacy/test_build_ignore_integration.py
Outdated
Show resolved
Hide resolved
|
Hooray! Thanks @blorente . |
**Problem** The cron job was not configured to bootstrap the 3.6 version of pants, and therefore when we added the "3.6 + pantsd" shards in #7440, these don't work. **Solution** To add the 3.6 bootstrapping shards to the cron job. **Result** The cron job should now work, maybe?
This is a WIP to iterate on the blockers to enable pantsd in Travis.