Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pantsd] Make PantsDaemonIntegrationTestBase hermetic. #7525

Closed
blorente opened this issue Apr 10, 2019 · 1 comment
Closed

[pantsd] Make PantsDaemonIntegrationTestBase hermetic. #7525

blorente opened this issue Apr 10, 2019 · 1 comment

Comments

@blorente
Copy link
Contributor

In the context of #7320 (and the PR #7440), it was noted that the environment variable PANTS_SHUTDOWN_PANTSD_AFTER_RUN could leak into pantsd integration tests, making them crash. However, making these tests hermetic is a non-trivial amount of work, since some of them need huge chunks of configuration added back to work.
@blorente blorente mentioned this issue Apr 10, 2019
Merged
@stuhood stuhood assigned patliu85 and unassigned patliu85 Apr 16, 2019
@stuhood
Copy link
Member

stuhood commented May 10, 2020

The pantsd tests now run under v2 in CI, and so are isolated from their environment.

@stuhood stuhood closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuhood @blorente @patliu85