Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Node.js and Yarnpkg to currently used versions #6341

Closed

Conversation

jdh339
Copy link

@jdh339 jdh339 commented Aug 13, 2018

Problem

The default Node.js and Yarnpkg versions in Pants haven't been updated in some time.

Solution

This bump brings OSS Pants up to date with the Node.js and Yarnpkg versions currently used at Twitter.

In the future, we plan to bump OSS Pants as updates are rolled out to Twitter.

@stuhood
Copy link
Member

stuhood commented Aug 13, 2018

Thanks, looks good to me! Travis has been flaky... I've restarted the failing shards.

@stuhood
Copy link
Member

stuhood commented Aug 14, 2018

@jdh339 : According to the travis errors, it looks like these versions have not been published to https://github.com/pantsbuild/binaries

@jdh339
Copy link
Author

jdh339 commented Aug 14, 2018

@stuhood Thanks. Ah, I see that we didn't add our changes to pantsbuild/binaries with our update back in June. I can do that now.

@stuhood
Copy link
Member

stuhood commented Aug 14, 2018

Merged the binary release... re-running these shards.

@stuhood
Copy link
Member

stuhood commented Aug 14, 2018

@jdh339 : Looks like there are some real failures in CI now! cc @nsaechao .

You can use:

./build-support/bin/get_failing_travis_targets_for_pr.sh 6341

to fetch them and their logs.

stuhood pushed a commit that referenced this pull request Sep 18, 2018
### Problem
The version of Node.js and Yarnpkg in Pants is outdated by a year. This is duplicating #6341, but has fixes to the Travis CI test failures.

### Solution
Upgrade Node.js to v8.11.3 and Yarnpkg to v1.6.0

### Result
Node.js is by default v8.11.3 and Yarnpkg to v1.6.0
@nsaechao
Copy link
Contributor

#6512 should have resolved this issue. Please feel free to close @jdh339 @stuhood

@stuhood stuhood closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants