Skip to content

Commit

Permalink
Upgrade Node.js to 8.11.3 and Yarn to 1.6.0 (#6512)
Browse files Browse the repository at this point in the history
### Problem
The version of Node.js and Yarnpkg in Pants is outdated by a year. This is duplicating #6341, but has fixes to the Travis CI test failures.

### Solution
Upgrade Node.js to v8.11.3 and Yarnpkg to v1.6.0

### Result
Node.js is by default v8.11.3 and Yarnpkg to v1.6.0
  • Loading branch information
nsaechao authored and Stu Hood committed Sep 18, 2018
1 parent 3d94661 commit 3a064e8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class NodeDistribution(NativeTool):

options_scope = 'node-distribution'
name = 'node'
default_version = 'v6.9.1'
default_version = 'v8.11.3'
archive_type = 'tgz'

@classmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ class YarnpkgDistribution(NativeTool):

options_scope = 'yarnpkg-distribution'
name = 'yarnpkg'
default_version = 'v0.19.1'
default_version = 'v1.6.0'
archive_type = 'tgz'
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _run_javascriptstyle(self, target, bootstrap_dir, files, config=None, ignore
if ignore_patterns:
# Wrap ignore-patterns in quotes to avoid conflict with shell glob pattern
args.extend([arg for ignore_args in ignore_patterns
for arg in ['--ignore-pattern', '"{}"'.format(ignore_args)]])
for arg in ['--ignore-pattern', '{}'.format(ignore_args)]])
if other_args:
args.extend(other_args)
args.extend(files)
Expand Down

0 comments on commit 3a064e8

Please sign in to comment.