Tighten PytestRun coverage plugin.
#5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-name coverage plugin classes to reflect their roles and re-name the coverage plugin module in the pytest binary chroot to avoid the needless complication of sharing packages with pants code and thus previously needing namespace packages where none otherwise would be needed.
benjyw
approved these changes
Mar 5, 2018
stuhood
approved these changes
Mar 6, 2018
| enclosing_dir = os.path.dirname(__name__.replace('.', os.sep)) | ||
| plugin_path = os.path.join(enclosing_dir, 'coverage/plugin.py') | ||
| yield self.ExtraFile(path=plugin_path, | ||
| yield self.ExtraFile(path='{}.py'.format(self.PytestBinary.coverage_plugin_module()), |
There was a problem hiding this comment.
This is going to refer to a different file than it used to... but the tests are passing, so I'm going to assume that that is intentional?
There was a problem hiding this comment.
The tests ride above the layer of the task, they just create it and execute it and so plugin details (for both py.test and coverage) are opaque - though important - to the test. The key paired change to this one is in PytestRun where PytestPrep.PytestBinary.coverage_plugin_module() is used to setup the coverage.rc ini file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-name coverage plugin classes to reflect their roles and re-name the
coverage plugin module in the pytest binary chroot to avoid the needless
complication of sharing packages with pants code and thus previously
needing namespace packages where none otherwise would be needed.
Addresses feedback in #5534 and #5535