Improve py.test covered paths reporting. #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 1, 2018
This change reverts the majority of pantsbuild#5400 (GatherSources) and adjusts the new coverage plugin path mapping system to handle mapping a single source chroot back to potentially multiple source roots. The existing tests of this capability introduced in pantsbuild#5400 still pass and as a result the previously conflicting use cases represented by pantsbuild#5314 (multiple library/binary source roots with interdependencies under test) and pantsbuild#5426 (parallel test packages in a test source root) are now both satisfied. Fixes pantsbuild#5314 Fixes pantsbuild#5426 Depends on pantsbuild#5534
stuhood
approved these changes
Mar 1, 2018
| # environment. | ||
| pythonpath = env.pop('PYTHONPATH', None) | ||
| if pythonpath: | ||
| self.context.log.warn('scrubbed PYTHONPATH={} from py.test environment'.format(pythonpath)) |
There was a problem hiding this comment.
Presumably there is there some other scrubbing happening higher in the stack that will prevent this warning from triggering spuriously in a venv, for example? Easy to remove later.
There was a problem hiding this comment.
There is not! When you pass a custom env to pex.run it accepts you know what you're doing.
wisechengyi
pushed a commit
that referenced
this pull request
Mar 1, 2018
This change reverts the majority of #5400 (GatherSources) and adjusts the new coverage plugin path mapping system to handle mapping a single source chroot back to potentially multiple source roots. The existing tests of this capability introduced in #5400 still pass and as a result the previously conflicting use cases represented by #5314 (multiple library/binary source roots with interdependencies under test) and #5426 (parallel test packages in a test source root) are now both satisfied. Fixes #5314 Fixes #5426 Depends on #5534
Use a coverage plugin instead of `coverage combine` to open the door to using a single PEX test source chroot even when testing against multiple repo source roots at once. Needed for pantsbuild#5426 Depends on pantsbuild#5420
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 1, 2018
This change reverts the majority of pantsbuild#5400 (GatherSources) and adjusts the new coverage plugin path mapping system to handle mapping a single source chroot back to potentially multiple source roots. The existing tests of this capability introduced in pantsbuild#5400 still pass and as a result the previously conflicting use cases represented by pantsbuild#5314 (multiple library/binary source roots with interdependencies under test) and pantsbuild#5426 (parallel test packages in a test source root) are now both satisfied. Fixes pantsbuild#5314 Fixes pantsbuild#5426 Depends on pantsbuild#5534
benjyw
reviewed
Mar 1, 2018
jsirois
added a commit
that referenced
this pull request
Mar 2, 2018
This change reverts the majority of #5400 (GatherSources) and adjusts the new coverage plugin path mapping system to handle mapping a single source chroot back to potentially multiple source roots. The existing tests of this capability introduced in #5400 still pass and as a result the previously conflicting use cases represented by #5314 (multiple library/binary source roots with interdependencies under test) and #5426 (parallel test packages in a test source root) are now both satisfied. Fixes #5314 Fixes #5426 Depends on #5534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a coverage plugin instead of
coverage combineto open the door tousing a single PEX test source chroot even when testing against multiple
repo source roots at once.
Fixes #5314
Needed for #5426
Depends on #5420