Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wheels when loading plugins. #4887

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Support wheels when loading plugins. #4887

merged 1 commit into from
Sep 25, 2017

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Sep 24, 2017

Fixes #4877

@jsirois jsirois requested review from benjyw, kwlzn and stuhood September 24, 2017 23:53
@jsirois
Copy link
Contributor Author

jsirois commented Sep 24, 2017

NB: I tested the removal of the precedence argument to resolver.resolve on an OSX system that previously reproed non-wheel installation problems with ssl headers. IOW - the default precedence for modern pex (which we depend on), correctly resolves wheel files when available. The new wheel activation code added was tested on linux - w/o this code, activation of wheels was failing in the same way on OSX.

benjyw
benjyw approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for taking this on.

kwlzn
kwlzn approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jsirois jsirois merged commit 65cc90b into pantsbuild:master Sep 25, 2017
@jsirois jsirois deleted the jsirois/issues/4877 branch September 25, 2017 18:20
@jsirois jsirois mentioned this pull request Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@kwlzn kwlzn kwlzn approved these changes

@stuhood stuhood Awaiting requested review from stuhood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsirois @benjyw @kwlzn