-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer wheels during plugin install #4877
Comments
I'm still not fully sure about the comment. That said, adding |
OK, newer setuptools cannot in fact deal with wheels in raw form, but adding some plugin resolution code to install wheels and activate them does the trick. PR soon. |
thanks @jsirois ! |
Pants has sprouted a dependency on a package that is most easily installed via a
whl
on pypi (openssl
forrequests[security]
).But currently the plugin installation infrastructure does not enable usage of
WheelPackage
due to a defensive avoidance of assuming thatwheel
is installed in an environment that pants is being loaded from:pants/src/python/pants/init/plugin_resolver.py
Lines 79 to 82 in e0d5108
As far as @kwlzn or I can tell,
wheel
should always be on the PYTHONPATH, as pants itself depends on it: it's not clear that it actually needs to be "installed" on the PATH as well.cc @jsirois for any context he might have on that comment.
The text was updated successfully, but these errors were encountered: