Add mechanism to deprecate target types and fields #10966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
requested review from
benjyw,
tdyas,
cosmicexplorer and
gshuflin
Eric-Arellano
commented
Oct 15, 2020
There was a problem hiding this comment.
The motivation is #10963. Raúl shared that it would be helpful with the migration if we add back removed fields like coverage, even if they no-op.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Merged
gshuflin
pushed a commit
that referenced
this pull request
Oct 16, 2020
Internal-only changes left off: * Add mechanism to deprecate target types and fields (Cherry-pick of #10966) (#10969) `PR #10969 <https://github.com/pantsbuild/pants/pull/10969>`_ * Use `package` to build Pants's wheels, rather than `setup-py` (Cherry-pick of #10947) (#10952) `PR #10952 <https://github.com/pantsbuild/pants/pull/10952>`_
Eric-Arellano
added a commit
that referenced
this pull request
Oct 16, 2020
Internal-only changes left off: * Add mechanism to deprecate target types and fields (Cherry-pick of #10966) (#10969) `PR #10969 <https://github.com/pantsbuild/pants/pull/10969>`_ * Use `package` to build Pants's wheels, rather than `setup-py` (Cherry-pick of #10947) (#10952) `PR #10952 <https://github.com/pantsbuild/pants/pull/10952>`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leave off deprecated target types and fields from
./pants target-typesfor now. In a followup, we may want to do something like./pants helpwhere it shows the values, but in red.We only log on the original targets in BUILD files, rather than on generated subtargets. This avoids unnecessary noise, where one target owning 7 source files would have had resulted in 8 different warnings.
[ci skip-rust]
[ci skip-build-wheels]