Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use package to build Pants's wheels, rather than setup-py #10947

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Use package to build Pants's wheels, rather than setup-py #10947

merged 1 commit into from
Oct 12, 2020

Conversation

Eric-Arellano
Copy link
Contributor

This also removes some overly chatty logging.

  • [INFO] Find all code to be published in the distribution isn't very descriptive because it's the same message for every single distribution
  • [INFO] Run setuptools for src/python/pants/testutil:testutil_wheel isn't very helpful because we very quickly thereafter will write Wrote dist/pantsbuild.pants.testutil.

[ci skip-rust]

@Eric-Arellano
Use package to build Pants's wheels, rather than setup-py
e595770 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Eric-Arellano
Eric-Arellano commented Oct 12, 2020
View reviewed changes
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjyw for #10919. This is great that we can move this information out of a script into BUILD files.

benjyw
benjyw approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, looks like we made the same change more or less. Mine also fixed up some var shadowing, but I can do those again at some later date. So I'll close that one.

@benjyw benjyw mentioned this pull request Oct 12, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling e595770 on Eric-Arellano:setup-py-release into 969c8dc on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit e0dda3d into pantsbuild:master Oct 12, 2020
@Eric-Arellano Eric-Arellano deleted the setup-py-release branch October 12, 2020 23:29
@Eric-Arellano Eric-Arellano restored the setup-py-release branch October 12, 2020 23:45
Eric-Arellano added a commit that referenced this pull request Oct 13, 2020
@Eric-Arellano
Use package to build Pants's wheels, rather than setup-py (Cherry…
ee28d2c 
…-pick of #10947) (#10952)

[ci skip-rust]
@Eric-Arellano Eric-Arellano deleted the setup-py-release branch October 13, 2020 00:44
@Eric-Arellano Eric-Arellano mentioned this pull request Oct 15, 2020
Merged
gshuflin pushed a commit that referenced this pull request Oct 16, 2020
@Eric-Arellano
Prepare 2.0.0rc1 (#10972)
fcd4523 
Internal-only changes left off:

* Add mechanism to deprecate target types and fields (Cherry-pick of #10966) (#10969)
  `PR #10969 <https://github.com/pantsbuild/pants/pull/10969>`_

* Use `package` to build Pants's wheels, rather than `setup-py` (Cherry-pick of #10947) (#10952)
  `PR #10952 <https://github.com/pantsbuild/pants/pull/10952>`_
Eric-Arellano added a commit that referenced this pull request Oct 16, 2020
@Eric-Arellano
Prepare 2.0.0rc1 (#10972)
30562d0 
Internal-only changes left off:

* Add mechanism to deprecate target types and fields (Cherry-pick of #10966) (#10969)
  `PR #10969 <https://github.com/pantsbuild/pants/pull/10969>`_

* Use `package` to build Pants's wheels, rather than `setup-py` (Cherry-pick of #10947) (#10952)
  `PR #10952 <https://github.com/pantsbuild/pants/pull/10952>`_
@gshuflin gshuflin mentioned this pull request Oct 30, 2020
Merged
gshuflin added a commit that referenced this pull request Oct 31, 2020
@gshuflin
Prepare 2.1.0.dev0 (#11089)
bf5e789 
Internal-only changes: 

* upgrade to cpython crate v0.5.1 (#11052)
  `PR #11052 <https://github.com/pantsbuild/pants/pull/11052>`_

* Prepare 2.0.0 (#11053)
  `PR #11053 <https://github.com/pantsbuild/pants/pull/11053>`_

* Revert "Add new EngineAware method metadata() (#11030)" (#11047)
  `PR #11030 <https://github.com/pantsbuild/pants/pull/11030>`_
  `PR #11047 <https://github.com/pantsbuild/pants/pull/11047>`_

* Remove deprecated `python_binary` target in favor of `pex_binary` (#11046)
  `PR #11046 <https://github.com/pantsbuild/pants/pull/11046>`_

* Prepare 2.0.0rc3 (#11044)
  `PR #11044 <https://github.com/pantsbuild/pants/pull/11044>`_

* Eagerly validate entry points for `setup_py().with_binaries()` (#11034)
  `PR #11034 <https://github.com/pantsbuild/pants/pull/11034>`_
  `PR #11021 <https://github.com/pantsbuild/pants/pull/11021>`_

* Use Ubuntu Bionic for CI (#11027)
  `PR #11027 <https://github.com/pantsbuild/pants/pull/11027>`_

* Prepare 2.0.0rc2 (#11017)
  `PR #11017 <https://github.com/pantsbuild/pants/pull/11017>`_

* Remove RunTrackerLogger (#11018)
  `PR #11018 <https://github.com/pantsbuild/pants/pull/11018>`_

* Upgrade Pex to 2.1.20 (#11014)
  `PR #11014 <https://github.com/pantsbuild/pants/pull/11014>`_

* Remove more unused code from RunTracker (#11012)
  `PR #11012 <https://github.com/pantsbuild/pants/pull/11012>`_

* Add type annotations to AggregatedTimings (#11009)
  `PR #11009 <https://github.com/pantsbuild/pants/pull/11009>`_

* Increase default `[python-setup].resolver_jobs` to `cpu_count / 2` (#11006)
  `PR #11006 <https://github.com/pantsbuild/pants/pull/11006>`_

* Include `<PYENV>` in `[python-setup].interpreter_search_paths` default (#10998)
  `PR #10998 <https://github.com/pantsbuild/pants/pull/10998>`_

* Remove PantsDaemonStats class wrapper (#11003)
  `PR #11003 <https://github.com/pantsbuild/pants/pull/11003>`_
  `PR #files#r508861045 <https://github.com/pantsbuild/pants/pull/11000/files#r508861045>`_

* Revert using libCST for dep inference due to performance (#10907) (#11001)
  `PR #10907 <https://github.com/pantsbuild/pants/pull/10907>`_
  `PR #11001 <https://github.com/pantsbuild/pants/pull/11001>`_


* Run tracker refactor (#11000)
  `PR #11000 <https://github.com/pantsbuild/pants/pull/11000>`_

* refactor Core::new including command runner setup (#10993)
  `PR #10993 <https://github.com/pantsbuild/pants/pull/10993>`_
  `PR #10960 <https://github.com/pantsbuild/pants/pull/10960>`_

* Allow changing the versioning scheme for `python_distribution` first-party dependencies (#10977)
  `PR #10977 <https://github.com/pantsbuild/pants/pull/10977>`_

* Remove tokio Handle type from Executor::new (#10980)
  `PR #10980 <https://github.com/pantsbuild/pants/pull/10980>`_

* Remove deprecated `Address.parse()` and `Address.reference()` (#10981)
  `PR #10981 <https://github.com/pantsbuild/pants/pull/10981>`_

* Remove project_ methods from the externs module (#10955)
  `PR #10955 <https://github.com/pantsbuild/pants/pull/10955>`_

* Prepare 2.0.0rc1 (#10972)
  `PR #10972 <https://github.com/pantsbuild/pants/pull/10972>`_

* Fix interpreter selection when building a PEX to use `[python-setup].interpreter_search_paths` (#10965)
  `PR #10965 <https://github.com/pantsbuild/pants/pull/10965>`_

* Delete `JsonReporter` (#10964)
  `PR #10964 <https://github.com/pantsbuild/pants/pull/10964>`_

* Fix log (#10959)
  `PR #10959 <https://github.com/pantsbuild/pants/pull/10959>`_

* Expose getattr method for Python-related APIs (#10953)
  `PR #10953 <https://github.com/pantsbuild/pants/pull/10953>`_

* Upgrade tokio package to 0.2.22 (#10949)
  `PR #10949 <https://github.com/pantsbuild/pants/pull/10949>`_

* Use `package` to build Pants's wheels, rather than `setup-py` (#10947)
  `PR #10947 <https://github.com/pantsbuild/pants/pull/10947>`_

* Simplify val_to_str and have it and val_to_log_level use PyObject (#10946)
  `PR #10946 <https://github.com/pantsbuild/pants/pull/10946>`_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@tdyas tdyas Awaiting requested review from tdyas

@gshuflin gshuflin Awaiting requested review from gshuflin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eric-Arellano @coveralls @benjyw