Add error message for tz_localize #32979
Conversation
|
Thanks @sumanau7 can you merge master. |
|
@simonjayhawkins Don't see the option to merge, request you to do the same. |
|
the merge is to get the changes in #32929 shown in the diff for before review. see https://pandas.pydata.org/docs/development/contributing.html#updating-your-pull-request sorry the request should have been to merge upstream master |
sumanau7
force-pushed
the
BUG-32967
branch
3 times, most recently
from
5030d13 to
58de83c
Compare
|
@simonjayhawkins is the failing test related ? |
known issue, see #33077 |
|
Green |
|
@sumanau7 can you merge master and update for the comment above |
|
sorry accid closed |
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -71,7 +71,7 @@ Other enhancements | |||
| - Positional slicing on a :class:`IntervalIndex` now supports slices with ``step > 1`` (:issue:`31658`) | |||
| - :class:`Series.str` now has a `fullmatch` method that matches a regular expression against the entire string in each row of the series, similar to `re.fullmatch` (:issue:`32806`). | |||
| - :meth:`DataFrame.sample` will now also allow array-like and BitGenerator objects to be passed to ``random_state`` as seeds (:issue:`32503`) | |||
| - | |||
| - `OutOfBoundsDatetime` publishes an error message when timestamp is out of implementation bounds. (:issue:`32967`) | |||
There was a problem hiding this comment.
double tickmarks for OutOfBoundsDatetime, "publishes" -> "issues"
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -71,7 +71,7 @@ Other enhancements | |||
| - Positional slicing on a :class:`IntervalIndex` now supports slices with ``step > 1`` (:issue:`31658`) | |||
| - :class:`Series.str` now has a `fullmatch` method that matches a regular expression against the entire string in each row of the series, similar to `re.fullmatch` (:issue:`32806`). | |||
| - :meth:`DataFrame.sample` will now also allow array-like and BitGenerator objects to be passed to ``random_state`` as seeds (:issue:`32503`) | |||
| - | |||
| - `OutOfBoundsDatetime` publishes an error message when timestamp is out of implementation bounds. (:issue:`32967`) | |||
There was a problem hiding this comment.
can you move this to the Datetimelike section in Bug FIxes
|
also pls merge master (conflict) |
| @@ -101,7 +101,6 @@ Other enhancements | |||
| - :meth:`~pandas.core.groupby.GroupBy.transform` has gained ``engine`` and ``engine_kwargs`` arguments that supports executing functions with ``Numba`` (:issue:`32854`) | |||
| - :meth:`~pandas.core.resample.Resampler.interpolate` now supports SciPy interpolation method :class:`scipy.interpolate.CubicSpline` as method ``cubicspline`` (:issue:`33670`) | |||
| - | |||
|
|
|||
There was a problem hiding this comment.
Could you undo this removed line?
| elif obj.dts.year == 2262: | ||
| if not (obj.value > 0): | ||
| raise OutOfBoundsDatetime | ||
| raise OutOfBoundsDatetime( | ||
| f'Timestamp cannot be converted within implementation bounds' |
There was a problem hiding this comment.
I think we wanted to give a sense of what the implementation bound was? e.g. f'Timestamp cannot be converted past {Timestamp.max}'
|
@sumanau7 Could you merge master and address the review comments? |
|
closing as stale, if you'd like to continue pls ping. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff