Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty error message in tz_localize #32967

Closed
quangngd opened this issue Mar 24, 2020 · 6 comments · Fixed by #35187
Closed

Empty error message in tz_localize #32967

quangngd opened this issue Mar 24, 2020 · 6 comments · Fixed by #35187
Assignees
Labels
Error Reporting Incorrect or improved errors from pandas good first issue
Milestone

Comments

@quangngd
Copy link
Contributor

Code Sample, a copy-pastable example if possible

# Your code here
from pandas import Timestamp
Timestamp.min.tz_localize("Asia/Tokyo")

The example is picked directly from
pandas/tests/scalar/timestamp/test_timezones.py::TestTimestampTZOperations::test_tz_localize_pushes_out_of_bounds

Problem description

Error message is empty.

yep, out of scope. but if you could raise an issue, that'll be great.

Originally posted by @simonjayhawkins in #32929

Expected Output

Meaningful error message

Output of pd.show_versions()

INSTALLED VERSIONS

commit : bbfecaf
python : 3.7.6.final.0
python-bits : 64
OS : Linux
OS-release : 5.3.0-40-generic
Version : #32-Ubuntu SMP Fri Jan 31 20:24:34 UTC 2020
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

pandas : 1.1.0.dev0+943.gbbfecaffa
numpy : 1.18.1
pytz : 2019.3
dateutil : 2.8.1
pip : 20.0.2
setuptools : 46.0.0.post20200311
Cython : 0.29.15
pytest : 5.4.1
hypothesis : 5.6.0
sphinx : 2.4.4
blosc : None
feather : None
xlsxwriter : 1.2.8
lxml.etree : 4.5.0
html5lib : 1.0.1
pymysql : None
psycopg2 : None
jinja2 : 2.11.1
IPython : 7.13.0
pandas_datareader: None
bs4 : 4.8.2
bottleneck : 1.3.2
fastparquet : 0.3.3
gcsfs : None
matplotlib : 3.2.0
numexpr : 2.7.1
odfpy : None
openpyxl : 3.0.3
pandas_gbq : None
pyarrow : 0.16.0
pytables : None
pyxlsb : 1.0.6
s3fs : 0.4.0
scipy : 1.4.1
sqlalchemy : 1.3.15
tables : 3.6.1
tabulate : 0.8.6
xarray : 0.15.0
xlrd : 1.2.0
xlwt : 1.3.0
numba : 0.48.0

@simonjayhawkins simonjayhawkins added the Error Reporting Incorrect or improved errors from pandas label Mar 24, 2020
@simonjayhawkins
Copy link
Member

Thanks @quangngd for posting this.

@sathyz
Copy link
Contributor

sathyz commented Mar 24, 2020

@quangngd shall I work on this?

@quangngd
Copy link
Contributor Author

@quangngd shall I work on this?

sure, please go ahead and take it

@sumanau7
Copy link
Contributor

take

@sathyz sathyz removed their assignment Mar 25, 2020
@jreback jreback added this to the 1.1 milestone Mar 29, 2020
@TomAugspurger
Copy link
Contributor

PR was closed as stale if anyone wants to pick this up.

@TomAugspurger TomAugspurger modified the milestones: 1.1, Contributions Welcome Jul 7, 2020
@gabrielNT
Copy link
Contributor

take

gabrielNT added a commit to gabrielNT/pandas that referenced this issue Jul 9, 2020
@jreback jreback modified the milestones: Contributions Welcome, 1.1 Jul 9, 2020
jreback pushed a commit that referenced this issue Jul 16, 2020
* Add date overflow message to tz_localize (#32967)

* Delay evaluating timestamp
fangchenli pushed a commit to fangchenli/pandas that referenced this issue Jul 16, 2020
…ev#35187)

* Add date overflow message to tz_localize (pandas-dev#32967)

* Delay evaluating timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas good first issue
Projects
None yet
7 participants