-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: isort init files #26671
WIP: isort init files #26671
Conversation
Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-08 11:14:01 UTC |
@alimcmaster1 can you please rebase? I think there was something wrong in master that was causing the CI to be red. Also, do you mind editing the description with info about the changes not directly specified in the ticket. Was it required for the issue to fix the sorts in the files you removed from |
Codecov Report
@@ Coverage Diff @@
## master #26671 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.01%
==========================================
Files 174 174
Lines 50703 50712 +9
==========================================
+ Hits 46538 46543 +5
- Misses 4165 4169 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26671 +/- ##
==========================================
- Coverage 91.78% 41.79% -50%
==========================================
Files 174 174
Lines 50703 50672 -31
==========================================
- Hits 46538 21177 -25361
- Misses 4165 29495 +25330
Continue to review full report at Codecov.
|
@datapythonista - ill split this PR up I was removing the |
#LondonPythonSprints
git diff upstream/master -u -- "*.py" | flake8 --diff