Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove isort from CI dependencies #26661

Closed
datapythonista opened this issue Jun 5, 2019 · 1 comment · Fixed by #26732
Closed

CI: Remove isort from CI dependencies #26661

datapythonista opened this issue Jun 5, 2019 · 1 comment · Fixed by #26732
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Milestone
0.25.0

Comments

@datapythonista
Copy link
Member

In #25455 we added isort as a dependency to all our builds. Looks like the CI was failing, and adding isort fixed the problem. Not sure what the problem is, but isort is something we should only have in environment.yml, as it's only used in ci/code_checks.sh and locally.

We should remove isort from all files in ci/deps/ and if the CI complains, find out what's the problem, and fix it.
@datapythonista datapythonista added CI Continuous Integration Dependencies Required and optional dependencies labels Jun 5, 2019
@alimcmaster1
Copy link
Member

Currently taking a look :)

This was referenced Jun 5, 2019
Closed
Merged
@jreback jreback added this to the 0.25.0 milestone Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Remove isort dep
WIP: isort init files
3 participants
@jreback @datapythonista @alimcmaster1