implement masked_arith_op to de-duplicate ops code #22182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22182 +/- ##
==========================================
+ Coverage 92.08% 92.08% +<.01%
==========================================
Files 169 169
Lines 50704 50695 -9
==========================================
- Hits 46691 46683 -8
+ Misses 4013 4012 -1
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
gfyoung
reviewed
Aug 3, 2018
pandas/core/ops.py
Outdated
| op : binary operator | ||
| """ | ||
| xrav = x.ravel() # 2D compat | ||
| assert isinstance(x, (np.ndarray, ABCSeries)), type(x) |
There was a problem hiding this comment.
Can we provide a more informative error message than just the type of x?
There was a problem hiding this comment.
This comment BTW applies to all of the assert statements that you added.
|
looks ok, if you can comment a bit more, this consolidates a gnarly bit of code, which is full of special cases. and rebase. |
|
thanks |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM _arith_method_SERIES and _arith_method_FRAME have really similar fallback code. This de-duplicates those.
git diff upstream/master -u -- "*.py" | flake8 --diff