Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor][UI/UX] Reducing permanent memory occupation from Starter Select and Pokédex #5351

Draft
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 16, 2025

What are the changes the user will see?

Why am I making these changes?

After the introduction of the internal Pokédex, existing issues on mobile due to excessive memory consumption have been exacerbated. This is, in large part, due to the fact that some heavy data structures in both the Pokédex and the Starter Select screen are permanently saved in memory. With the present changes, these structures are only saved in memory while either screen is open.

What are the changes from a developer perspective?

Screenshots/Videos

See comments

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha
Copy link
Contributor Author

Memory occupation before the changes (using dev tools on Edge):

After starting the game
snap_title_5_1

After opening and closing the Pokédex
snap_title_5_2

================================================

Memory occupation after the changes (using dev tools on Edge):

After starting the game
snap_title_4_1

After opening the Pokédex
snap_pokedex_4

After closing the Pokédex
snap_title_4_2

@Wlowscha Wlowscha changed the title [Refactor][UI/UX] Reducing permament memory occupation from Starter Select and Pokédex [Refactor][UI/UX] Reducing permanent memory occupation from Starter Select and Pokédex Feb 16, 2025
@Madmadness65 Madmadness65 added UI/UX User interface/-experience related Refactor Rewriting existing code related labels Feb 16, 2025
@SirzBenjie SirzBenjie added the Performance Rewrites designed solely at improving existing performance label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Rewrites designed solely at improving existing performance Refactor Rewriting existing code related UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants