Add GitlabPullRequest.patch property #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
jpopelka
reviewed
Jul 14, 2021
ogr/services/gitlab/pull_request.py
Outdated
| @@ -106,6 +107,17 @@ def diff_url(self) -> str: | |||
| def commits_url(self) -> str: | |||
| return f"{self._raw_pr.web_url}/commits" | |||
|
|
|||
| @property | |||
| def patch(self) -> bytes: | |||
| response = requests.get(f"{self._raw_pr.web_url}.patch") | |||
There was a problem hiding this comment.
I see we already have a url property you can use:
Suggested change
| response = requests.get(f"{self._raw_pr.web_url}.patch") | |
| response = requests.get(f"{self.url}.patch") |
|
You'll also need to rebase since your other PR has been merged meanwhile and we (Franta ;-) ) want to have a straight git history. |
Implementated for GitlabPullRequest. It returns bytes in case there's some binary blob in the patch. It uses requests to get content from patch's URL.
nikromen
force-pushed
the
GitlabPullRequest.patch
branch
from
e65b196 to
8baf426
Compare
|
Build succeeded.
|
mfocko
approved these changes
Jul 15, 2021
jpopelka
approved these changes
Jul 15, 2021
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementated for GitlabPullRequest.
It returns bytes in case there's some binary blob in the patch.
It uses requests to get content from patch's URL.
Implementation for #416