New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement patch property in GitlabPullRequest and GithubPullRequest #416

Closed

jpopelka opened this issue May 22, 2020 · 6 comments

Assignees

Labels

area/github area/gitlab good-first-issue Hacktoberfest kind/feature

Member

jpopelka commented May 22, 2020 •

edited by lachmanfrantisek

Loading

#415 implements PagurePullRequest.patch property to get a patch from a pull request.
Gitlab & Github implementation are missing.

Update by @lachmanfrantisek :

The task is to implement patch property fo GithubPullRequest and GitlabPullRequest that will return patch of the changes for pull-request (not the URL of it).

Github:
- URL of patch: https://pygithub.readthedocs.io/en/latest/github_objects/PullRequest.html#github.PullRequest.PullRequest.patch_url
- The URL looks like this: https://patch-diff.githubusercontent.com/raw/packit/packit-service/pull/1003.patch
- But this one works as well: https://github.com/packit/ogr/issues/416.patch
Gitlab: https://python-gitlab.readthedocs.io/en/stable/gl_objects/mrs.html
- I am not sure if diffs will work.
- The same approach as in GitHub (adding .patch to the URL) works well: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/800.patch

The text was updated successfully, but these errors were encountered:

jpopelka added kind/feature area/github area/gitlab low-prio labels

jpopelka mentioned this issue

Add PullRequest.patch property #415

Merged

This comment has been minimized.

Sign in to view

stale bot added the stale label

mfocko removed the stale label

This comment has been minimized.

Sign in to view

stale bot added the stale label

lachmanfrantisek removed the stale label

lachmanfrantisek added Hacktoberfest good-first-issue and removed low-prio labels

This comment has been minimized.

Sign in to view

stale bot added the stale label

Member

lachmanfrantisek commented Nov 30, 2020

We might want to implement this to be able to have source-gits on GitLab.

stale bot removed the stale label

This comment has been minimized.

Sign in to view

stale bot added the stale label

lachmanfrantisek removed the area/github label

stale bot removed the stale label

lachmanfrantisek added the area/github label

This comment has been minimized.

Sign in to view

stale bot added the stale label

lachmanfrantisek removed the stale label

nikromen mentioned this issue

Add GitlabPullRequest.patch property #614

Merged

softwarefactory-project-zuul bot added a commit that referenced this issue


          Merge pull request #614 from nikromen/GitlabPullRequest.patch

3d2c776

Add GitlabPullRequest.patch property

Implementated for GitlabPullRequest.
It returns bytes in case there's some binary blob in the patch.
It uses requests to get content from patch's URL.
Implementation for #416

Reviewed-by: Jiri Popelka <None>
Reviewed-by: Matej Focko <None>

nikromen closed this as completed

nikromen mentioned this issue

Add GithubPullRequest.patch property #613

Merged

lachmanfrantisek assigned nikromen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment