Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minitable hover css #2666

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix minitable hover css #2666

merged 2 commits into from
Jan 28, 2025

Conversation

charliepark
Copy link
Contributor

A slight tweak to the CSS on mini-table cells. Previously, we highlighted the entire mini-table row on hover, but we really just want to highlight the div containing the button in the last cell.

With the fix in place, when hovering the mouse over the top row's last cell (though the mouse is removed from the screenshot):
Screenshot 2025-01-27 at 12 29 09 PM

Closes #2662

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jan 27, 2025 8:49pm

@david-crespo david-crespo merged commit 7771953 into main Jan 28, 2025
7 checks passed
@david-crespo david-crespo deleted the fix-minitable-hover-css branch January 28, 2025 21:20
charliepark added a commit to oxidecomputer/omicron that referenced this pull request Jan 28, 2025
oxidecomputer/console@d583ae7...288f1c1

* [288f1c1b](oxidecomputer/console@288f1c1b) oxidecomputer/console#2670
* [7771953d](oxidecomputer/console@7771953d) oxidecomputer/console#2666
* [28ea9518](oxidecomputer/console@28ea9518) oxidecomputer/console#2576
* [0878bcc3](oxidecomputer/console@0878bcc3) oxidecomputer/console#2668
* [dacb1028](oxidecomputer/console@dacb1028) oxidecomputer/console#2667
* [b4f2a966](oxidecomputer/console@b4f2a966) oxidecomputer/console#2658
* [13a8200d](oxidecomputer/console@13a8200d) chore: upgrade vite and vitest
* [7ec7d667](oxidecomputer/console@7ec7d667) oxidecomputer/console#2664
* [ba21b682](oxidecomputer/console@ba21b682) oxidecomputer/console#2655
* [a0bc4708](oxidecomputer/console@a0bc4708) oxidecomputer/console#2660
* [287a531d](oxidecomputer/console@287a531d) oxidecomputer/console#2659
* [b73255d4](oxidecomputer/console@b73255d4) chore: use design-system 2.1.0, 3.0 is no more
* [7a8615a0](oxidecomputer/console@7a8615a0) oxidecomputer/console#2638
* [0f704717](oxidecomputer/console@0f704717) oxidecomputer/console#2637
* [1e9d3f26](oxidecomputer/console@1e9d3f26) oxidecomputer/console#2650
* [6cd25c9f](oxidecomputer/console@6cd25c9f) oxidecomputer/console#2630
* [a629300f](oxidecomputer/console@a629300f) oxidecomputer/console#2648
* [b57531d9](oxidecomputer/console@b57531d9) oxidecomputer/console#2646
* [b55e1618](oxidecomputer/console@b55e1618) oxidecomputer/console#2642
* [a3e8216e](oxidecomputer/console@a3e8216e) tools: also lint for console.log in oxlint
* [a6f84049](oxidecomputer/console@a6f84049) oxidecomputer/console#2643
* [2fa9b424](oxidecomputer/console@2fa9b424) remove stray console.log in table header
* [c2ea0e3e](oxidecomputer/console@c2ea0e3e) oxidecomputer/console#2639
* [48e1b15a](oxidecomputer/console@48e1b15a) oxidecomputer/console#2598
* [d144e7dc](oxidecomputer/console@d144e7dc) oxidecomputer/console#2617
* [c147df00](oxidecomputer/console@c147df00) oxidecomputer/console#2628
* [63954c8a](oxidecomputer/console@63954c8a) oxidecomputer/console#2633
* [aa46e508](oxidecomputer/console@aa46e508) oxidecomputer/console#2631
* [892fc2e9](oxidecomputer/console@892fc2e9) oxidecomputer/console#2629
charliepark added a commit to oxidecomputer/omicron that referenced this pull request Jan 29, 2025
oxidecomputer/console@d583ae7...288f1c1

* [288f1c1b](oxidecomputer/console@288f1c1b)
oxidecomputer/console#2670
* [7771953d](oxidecomputer/console@7771953d)
oxidecomputer/console#2666
* [28ea9518](oxidecomputer/console@28ea9518)
oxidecomputer/console#2576
* [0878bcc3](oxidecomputer/console@0878bcc3)
oxidecomputer/console#2668
* [dacb1028](oxidecomputer/console@dacb1028)
oxidecomputer/console#2667
* [b4f2a966](oxidecomputer/console@b4f2a966)
oxidecomputer/console#2658
* [13a8200d](oxidecomputer/console@13a8200d)
chore: upgrade vite and vitest
* [7ec7d667](oxidecomputer/console@7ec7d667)
oxidecomputer/console#2664
* [ba21b682](oxidecomputer/console@ba21b682)
oxidecomputer/console#2655
* [a0bc4708](oxidecomputer/console@a0bc4708)
oxidecomputer/console#2660
* [287a531d](oxidecomputer/console@287a531d)
oxidecomputer/console#2659
* [b73255d4](oxidecomputer/console@b73255d4)
chore: use design-system 2.1.0, 3.0 is no more
* [7a8615a0](oxidecomputer/console@7a8615a0)
oxidecomputer/console#2638
* [0f704717](oxidecomputer/console@0f704717)
oxidecomputer/console#2637
* [1e9d3f26](oxidecomputer/console@1e9d3f26)
oxidecomputer/console#2650
* [6cd25c9f](oxidecomputer/console@6cd25c9f)
oxidecomputer/console#2630
* [a629300f](oxidecomputer/console@a629300f)
oxidecomputer/console#2648
* [b57531d9](oxidecomputer/console@b57531d9)
oxidecomputer/console#2646
* [b55e1618](oxidecomputer/console@b55e1618)
oxidecomputer/console#2642
* [a3e8216e](oxidecomputer/console@a3e8216e)
tools: also lint for console.log in oxlint
* [a6f84049](oxidecomputer/console@a6f84049)
oxidecomputer/console#2643
* [2fa9b424](oxidecomputer/console@2fa9b424)
remove stray console.log in table header
* [c2ea0e3e](oxidecomputer/console@c2ea0e3e)
oxidecomputer/console#2639
* [48e1b15a](oxidecomputer/console@48e1b15a)
oxidecomputer/console#2598
* [d144e7dc](oxidecomputer/console@d144e7dc)
oxidecomputer/console#2617
* [c147df00](oxidecomputer/console@c147df00)
oxidecomputer/console#2628
* [63954c8a](oxidecomputer/console@63954c8a)
oxidecomputer/console#2633
* [aa46e508](oxidecomputer/console@aa46e508)
oxidecomputer/console#2631
* [892fc2e9](oxidecomputer/console@892fc2e9)
oxidecomputer/console#2629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hover state from entire minitable row item
2 participants