Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oxc_transform): oxc dot define is postfix of some MemberExpr #7640

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Dec 4, 2024

Closed #7598

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title fix: oxc_define fix: oxc dot define is postfix of some MemberExpr Dec 4, 2024
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7640 will not alter performance

Comparing 12-04-fix_oxc_define (3ca323b) with main (0ce7ce7)

Summary

✅ 29 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 4, 2024 10:14
@IWANABETHATGUY IWANABETHATGUY changed the title fix: oxc dot define is postfix of some MemberExpr fix(oxc_transform): oxc dot define is postfix of some MemberExpr Dec 4, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Dec 4, 2024
@Boshen Boshen merged commit 64f92e9 into main Dec 4, 2024
26 of 27 checks passed
@Boshen Boshen deleted the 12-04-fix_oxc_define branch December 4, 2024 11:18
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define replaces property access incorrectly
2 participants