fix: oxc_define

oxc-project · Dec 4, 2024 · a0bcfb9 · a0bcfb9
1 parent e787e9d
commit a0bcfb9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/crates/oxc_transformer/src/plugins/replace_global_defines.rs b/crates/oxc_transformer/src/plugins/replace_global_defines.rs
@@ -538,7 +538,7 @@ impl<'a> ReplaceGlobalDefines<'a> {
             };
         }
 
-        true
+        current_part_member_expression.is_none()
     }
 }
 

diff --git a/crates/oxc_transformer/tests/integrations/plugins/replace_global_defines.rs b/crates/oxc_transformer/tests/integrations/plugins/replace_global_defines.rs
@@ -59,16 +59,15 @@ fn dot() {
     test("process['env'].NODE_ENV", "production", config.clone());
 }
 
-#[ignore]
 #[test]
 fn dot_with_overlap() {
     let config = ReplaceGlobalDefinesConfig::new(&[
-        ("import.meta.env.FOO", "import.meta.env.FOO"),
-        ("import.meta.env", "__foo__"),
+        ("__OBJ__", r#"{"process":{"env":{"SOMEVAR":"foo"}}}"#),
+        ("process.env.SOMEVAR", "\"foo\""),
     ])
     .unwrap();
-    test("import.meta.env", "__foo__", config.clone());
-    test("import.meta.env.NODE_ENV", "import.meta.env.NODE_ENV", config.clone());
+    test("console.log(__OBJ__.process.env.SOMEVAR)", "__foo__", config.clone());
+    // test("import.meta.env.FOO", "import.meta.env.FOO", config.clone());
 }
 
 #[test]
-Original file line number
+Diff line change
@@ Expand Up / @@ -538,7 +538,7 @@ impl<'a> ReplaceGlobalDefines<'a> { @@
                 };
             }
-            true
+            current_part_member_expression.is_none()
         }
     }
@@ Expand Down @@