Use reva's Authenticate method instead of spawning token managers #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishank011
force-pushed
the
reva-auth-tokens
branch
from
b54471d to
3e5286a
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
💥 Acceptance tests Core-API-Tests-ocis-storage-4 failed. The build is cancelled... |
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
ishank011
force-pushed
the
reva-auth-tokens
branch
from
3e5286a to
a2de720
Compare
ishank011
force-pushed
the
reva-auth-tokens
branch
from
a2de720 to
fcd861f
Compare
💥 Acceptance tests Core-API-Tests-ocis-storage-7 failed. The build is cancelled... |
💥 Acceptance tests settingsUITests failed. The build is cancelled... |
ishank011
force-pushed
the
reva-auth-tokens
branch
from
3607ed6 to
6e653ba
Compare
ishank011
force-pushed
the
reva-auth-tokens
branch
from
6e653ba to
fd2bf9c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
C0rby
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
@ishank011, I was working on this too but you were faster. ;)
Looks good to me. I'll change the other services in another PR.
ownclouders
pushed a commit
that referenced
this pull request
Sep 22, 2021
|
Thanks a lot @C0rby! |
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Feb 2, 2022
This we use reva to mint tokes for users when using the CS3 backend (owncloud#2528) the user's roles are no longer part of the token. This adds a workaround to the RequireSelfOrAdmin middleware to Request the user's role id on demand from the settings service. Partial Fix for owncloud#2646
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Feb 2, 2022
This we use reva to mint tokes for users when using the CS3 backend (owncloud#2528) the user's roles are no longer part of the token. This adds a workaround to the RequireSelfOrAdmin middleware to Request the user's role id on demand from the settings service. Partial Fix for owncloud#2646
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Feb 2, 2022
This we use reva to mint tokes for users when using the CS3 backend (owncloud#2528) the user's roles are no longer part of the token. This adds a workaround to the RequireSelfOrAdmin middleware to Request the user's role id on demand from the settings service. Partial Fix for owncloud#2646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CS3 proxy backend, we previously obtained the user from reva's userprovider service and minted the token ourselves. This required maintaining a shared JWT secret between ocis and reva, as well duplication of logic. This PR delegates this logic by using the
Authenticatemethod provided by the reva gateway service to obtain this token, making it an arbitrary, indestructible entry. Currently, the changes have been made to the proxy service but will be extended to others as well.Closes #2525