no oCIS roles with LDAP user backend

[wkloucek]

Describe the bug

Since the we now use reva's Authenticate method to Mint Tokens, the tokens no longer contain the user's oCIS roles (at least when using the CS3 account backend). So thinks like ReadRoleIDsFromContext, which rely on the roleIDs being present in the token, no longer work.

Steps to reproduce

1. Use the CS3 users deployment example
2. Login as einstein
3. Go to settings

Expected behavior

Settings are available

Actual behavior

Setup

CS3 users deployment example

Additional context

• introduced by Use reva's Authenticate method instead of spawning token managers #2528
• see also oC10 / oCIS parallel / migration deployment broke because of user authentication #2604

[rhafer]

@ishank011 Any idea how to bring back the ocis roles into the token? Could we somehow pass them down with the AuthenticateRequest in https://github.com/owncloud/ocis/blob/master/proxy/pkg/user/backend/cs3.go#L34? That would of course mean that we need to add another GetUserByClaim() call to lookup the user before that.

[wkloucek]

@rhafer do you know about the current state?

[rhafer]

Basically the above mentioned workaround are still in place I think. We're adding the roleID to the context in the account_resolver middleware in the proxy as well nowadays IIRC.

[wkloucek]

Ok, than I'm closing this for now, since the bug description is no longer valid.

Fixed by #3096