Mod interaction #93
Merged
Mod interaction #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bring mod interaction up to date with load order
…into mod-interaction
Mod interaction
- Added null checker to method invoke - Split ModDep into seperate file - Made ModSorter non-static
- Changed ModInteraction to Interaction - Removed "None" feature of dependencies
Add mod load order and mod interaction methods Merging @misternebula's work to branch on this repo
amazingalek
reviewed
Apr 29, 2020
- changed edge hashset declaration to use var - added "public" to ModSorter - removed false from ModManifest
Raicuparta
requested changes
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
May 1, 2020
| var dependencies = new List<IModBehaviour>(); | ||
| foreach (var dependency in _modList) | ||
| { | ||
| if (dependency.ModHelper.Manifest.Dependencies.Any() && dependency.ModHelper.Manifest.Dependencies.Contains(mod.ModHelper.Manifest.UniqueName)) |
There was a problem hiding this comment.
Pretty sure you can remove dependency.ModHelper.Manifest.Dependencies.Any() && and it'll work the same.
amazingalek
reviewed
May 1, 2020
amazingalek
reviewed
May 1, 2020
amazingalek
reviewed
May 1, 2020
Merged
|
Awesome, all that's left is testing. :) |
Raicuparta
previously approved these changes
May 5, 2020
amazingalek
pushed a commit
that referenced
this pull request
May 11, 2020
Added mod interaction methods, and improved Invoke method.
Raicuparta
added a commit
that referenced
this pull request
May 13, 2020
* Add VR patch for Outer Wilds update 1.0.6 * updated the readme (#87) * Owml manifest (#88) * owml manifest file * fixed error messages in storage helper (#89) * adaptations for the mod manager (#90) * removed (slow) version checking * added descriptions * updated readme * mods have separate logger and console objects (#91) * mods have separate logger and console objects * Logging some stuff to socket * Sending absolutely everything to socket * Cleanup * Pick between file and socket consoles * Console port argument constant * Simpler argument get * Add separate project for logging * Move all logging-related stuff to Logging project * Helper Output.cs * Use public property instead of getter / setter. * Simplified command line argument parsing * Socket creation early return * Exit console if socket port argument present * Remove this line that I don't know why I had in the first place * Use Output.OnWrite instead of ModConsole.OnConsole * Simplify decrecated event * Cleanup * Make Mod*Output extend from ModConsole * Mod interaction (#93) Added mod interaction methods, and improved Invoke method. * Simplify modsocketoutput constructor * Remove unnecessary statics * Revert "Remove unnecessary statics" This reverts commit 8dc0c63. * Revert ModConsole namespace * Rename ModConsole to ModOutput * Ouput factory * Remove redundant elses * Rename instance to OwmlOutput, remove deprecated * Cleanup * formatting, removed unused stuff * . * Using ExitConsole in two places * Name / message separator as const * version * Move ModHelper.Logging to ModHelper * Revert singletone instance * Remove references to Logging project * Rename protected variables * protected ModConsole constructor * Move logging stuff to Logging subdirectory * Update OW.Unity.Dlls to 1.0.5 * Bump version Co-authored-by: AmazingAlek <[email protected]> Co-authored-by: Mister_Nebula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79