-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Input API #94
Merged
Merged
Added Input API #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethodinfo Allow patching by providing MethodInfo
Add VR patch for Outer Wilds update 1.0.6
* owml manifest file
* removed (slow) version checking * added descriptions * updated readme
* mods have separate logger and console objects
I wonder if I should expose InputHandler's *_Combo methods, or just keep it simple |
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
amazingalek
reviewed
Apr 30, 2020
Some general comments:
|
TAIcheat is part of this only temporarily to showcase how InputHandler functions until either EnableDebugMod or LoadCustomAssets gets converted to use that system |
moved to nuget package potential bugfixes changed some stuff to internal
Raicuparta
reviewed
Apr 30, 2020
Raicuparta
requested changes
Apr 30, 2020
amazingalek
reviewed
May 20, 2020
amazingalek
reviewed
May 20, 2020
amazingalek
reviewed
May 20, 2020
amazingalek
reviewed
May 20, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
amazingalek
reviewed
Jun 26, 2020
changed EnableDebugMode to use ModInputHandler removed TAICheat changes suggested by Alek
moved ModInputHandler's ctor to the top
amazingalek
reviewed
Jun 26, 2020
changed the system for listening to game's bindings to a patch-less variant made blocking game's input optional
Raicuparta
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModLayoutButton: A button that has HorizontalLayoutGroup instead of Text
ModInputInput: somewhat similar to ModFieldInput, but has a nice visual representation of combos and in future will open modified input window, though some functionality could be easily moved to ModLayoutButton to make the latter more functionally complete
ModInputHandler: the input handler, can tell if registered combination is being pressed and tells the game to ignore buttons that are part of combination that's currently being pressed
ModCombination: object representation of combos, modders should use it for queries to ModInputHandler
There are also adjustments to ModHelper that pass InputHandler to mods with corresponding changes to Owo and ModLoader
Changes to ModsMenu, ModMenu and ModConfigMeny are to accomodate ModInputInput
HarmonyHelper was changed to allow patching of constructors, though many constructors seem to execute before execution of OWML (especially members of static classes)
I know that this is big commit, feel free to ask me if anything is not clear
PS sorry for changes to csproj files, couldn't figure out the OW.Unity.Dlls.1.0.2 thing