Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated config section in readme and changed wording of input config #212

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

amazingalek
Copy link
Collaborator

No description provided.

* updated config section in readme
private const string VerboseModeTitle = "Verbose mode";
private const string BlockInputTitle = "Mod button combinations block game input";
private const string BlockInputTitle = "Mod input combinations block game input";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a little confusing... I haven't been keeping up with the combinations stuff, so I have no idea what this means

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally. I've had it explained several times and I still don't quite get it. I tried to make it more understandable here, but not sure if I succeeded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's on InputHandler would for example block Shift from game while registered combination Shift+L is being pressed

Copy link
Member

@Raicuparta Raicuparta Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we stop calling it "combinations"? It's trying to refer to the shortcuts that mods can define as a mod setting. As in, "if this setting is set to true, inputs used by mods will block the actions that the same shortcut would cause in the base game". For instance, if you had a shortcut that includes the jump button, pressing that shortcut would cause the player to jump, unless this option is enabled.

Some examples that might be clearer:

  1. "Prevent game actions from being triggered by mod inputs" (disabled by default)
  2. "Mod inputs can block game actions" (disabled by default)
  3. "Allow mod inputs to also trigger game actions" (enabled by default)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I tried alt. 2

@amazingalek amazingalek changed the title removed gamepath from OWML config menu, updated config section in readme updated config section in readme and changed wording of input config Jul 21, 2020
@amazingalek amazingalek merged commit a4064a2 into dev Jul 22, 2020
@amazingalek amazingalek deleted the alek/owml-config-update branch July 22, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants