Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): interpret extensionless files as typescript #5711

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Conversation

paperclover
Copy link
Member

What does this PR do?

also fixes require('yargs/yargs'). im surprised we did not have an open issue about this.

Fixes #5173
Furthers #4207

i wrote automated tests

@Jarred-Sumner
Copy link
Collaborator

does not compile

@Jarred-Sumner Jarred-Sumner marked this pull request as draft September 19, 2023 13:51
@liz3
Copy link
Contributor

liz3 commented Sep 19, 2023

Another good testcase for this might be googles zx.
Since it is designed as a shell scripting system using the node ecosystem.

@paperclover paperclover marked this pull request as ready for review September 19, 2023 22:25
@paperclover
Copy link
Member Author

the build failure was a ci issue.

@paperclover
Copy link
Member Author

fixed linux test failure

@Jarred-Sumner
Copy link
Collaborator

yargs-cjs test is failing

@Jarred-Sumner
Copy link
Collaborator

LGTM.

@paperclover paperclover merged commit b795151 into main Sep 21, 2023
@paperclover paperclover deleted the dave/yargs branch September 21, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript does not work in shebang scripts
3 participants