addresses #1247

[michaelwagler]

#1247

[michaelwagler]

@aeneasr 👀when you get a chance

[aeneasr]

Thank you! To get tests working run:

$ export GO111MODULE=on
$ go get -u golang.org/x/crypto
$ git commit -a -m "vendor: Update crypto dependency"
$ git push origin

[aeneasr]

Would it make sense to test this against all methods?

[michaelwagler]

@aeneasr sounds good. I just added a whole bunch of tests, let me know if you have suggestions.

There's a lot of repetition so I wrote helpers that take the methods being tested as parameters. I think it mostly works, but there are a couple things that are a bit ugly:

-For the Access token and Refresh token tests, I call doTestCommit and do doTestRollback twice each, to account for them having both a revoke and delete method

-The OpenIdConnectSession tests couldn't use the helper functions, since GetOpenIDConnectSession has a different signature than all the other getter methods.

[aeneasr]

Nice!

[aeneasr]

Thank you, Michael!