Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fosite delegated transactions in SQL storage #1247

Closed
aaslamin opened this issue Dec 23, 2018 · 3 comments
Closed

Support fosite delegated transactions in SQL storage #1247

aaslamin opened this issue Dec 23, 2018 · 3 comments

Comments

@aaslamin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Certain oauth flows require transactional semantics (see issue linked below). Thanks to Fosite v0.29.0, Fosite will now attempt to initiate a transaction if the underlying storage provider has implemented the Transactional interface.

Describe the solution you'd like

  • Bump fosite to at least v0.29.0
  • Extend FositeSQLStore so that it implements Transactional
  • Modify all sql storage methods to first lookup for a transaction in the context (if one does not exist, its business as usual).
  • Test coverage of new behaviour

Additional context

ory/fosite#309
ory/fosite#343
@aeneasr
Copy link
Member

aeneasr commented Dec 23, 2018

👍

@aaslamin aaslamin mentioned this issue Jan 6, 2019
Closed
@aaslamin
Copy link
Contributor Author

My colleague, @michaelwagler, has decided to take this issue on for his first contribution to Hydra 🏆

@michaelwagler
Copy link
Contributor

Yup 👍

michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 5, 2019
@michaelwagler
vendor: Bump ory/x to 0.29.0 (ory#1247)
0012f65 
Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 5, 2019
@michaelwagler
sql: implements fosite's transactional interface (ory#1247)
0dcc18b 
Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 5, 2019
@michaelwagler
oath2: adds test coverage for BeginTX, Commit, and Rollback (ory#1247)
5978f4a 
Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 5, 2019
@michaelwagler
oath2: adds test coverage for BeginTX, Commit, and Rollback (ory#1247)
3b3bd7e 
Signed-off-by: Michael Wagler <[email protected]>
@michaelwagler michaelwagler mentioned this issue Feb 5, 2019
Merged
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 7, 2019
@michaelwagler
sql: renamed variables for clarity and modified FositeSqlStore.delete…
27c8847 
…Session to use transaction (ory#1247)

Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 7, 2019
@michaelwagler
oath2: Increased test coverage for Commit and Rollback, improved exis…
4cd22f6 
…ting tests (ory#1247)

Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 7, 2019
@michaelwagler
sql: renamed variables for clarity and modified FositeSqlStore.delete…
5ca573f 
…Session to use transaction (ory#1247)

Signed-off-by: Michael Wagler <[email protected]>
michaelwagler added a commit to michaelwagler/hydra that referenced this issue Feb 7, 2019
@michaelwagler
oath2: Increased test coverage for Commit and Rollback, improved exis…
9c0073b 
…ting tests (ory#1247)

Signed-off-by: Michael Wagler <[email protected]>
@aeneasr aeneasr closed this as completed in 65415ff Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaslamin @aeneasr @michaelwagler