feat: Add option for using monolithic push #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
thomastaylor312,
bacongobbler and
flavio
as code owners
flavio
requested changes
Oct 22, 2024
src/client.rs
Outdated
Comment on lines
562
to
564
| if self.config.use_monolithic_push { | ||
| self.push_blob_monolithically(image_ref, data, digest).await | ||
| } else { |
There was a problem hiding this comment.
Just a matter of personal taste, I would rewrite it get rid of the extra indentation caused by the else statement:
if self.config.use_monolithic_push {
return self.push_blob_monolithically(image_ref, data, digest).await;
} There was a problem hiding this comment.
Great suggestion, I've adjusted the code accordingly 👍
9 tasks
Signed-off-by: Joonas Bergius <[email protected]>
joonas
force-pushed
the
feat/use-monolithic-push
branch
from
145945d to
30c0b71
Compare
thomastaylor312
approved these changes
Oct 23, 2024
flavio
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #175 and #176, this rounds out the remaining set of functionality that's needed to use
rust-oci-clientfor pushing to GCP Artifact Registry similarly to howoras-gocan be used for this.This seemed like an option that should be available for configuring the client in case you're working with a registry that's not fully spec compliant.