feat: Relax location_header_to_url path handling #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing this library against Google Cloud Artifact Registry, I noticed the upload URL they return when obtaining a session id differs from the spec.
Instead of returning a
Location:
as specified in the OCI Distribution spec:GCP Artifactory Registry returns the following
Location:
header:I would like to propose relaxing the
location_header_to_url
code slightly to allow the use of this returned header, which does seem based to be on a perhaps slightly "looser interpretation" of what the spec says underPOST then PUT
:To further motivate this, 'd like to point out that the
oras-go
handles this without any issue, so it would seem reasonable to try to align the behavior between the two libraries in this regard.