[GR-42460] Add support for CgroupMetrics.getTotalMemory0 #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Note: This should also be backported to 22.3.1. |
zakkak
suggested changes
Nov 8, 2022
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/CgroupMetricsJDK.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/HasGetTotalMemorySize0.java
Outdated
Show resolved
Hide resolved
Yes. Thanks for the review! |
jerboaa
force-pushed
the
metrics_improvements_graal_5387
branch
from
f01f8d7 to
90d5c6b
Compare
Latest JDK code received an update to bound the reported container memory above by the total physical memory of the host running the container. Implement the same in GraalVM, only substituting the class/methods if they exist in the JDK. Closes oracle#5387
jerboaa
force-pushed
the
metrics_improvements_graal_5387
branch
from
90d5c6b to
3dcf7c7
Compare
zakkak
approved these changes
Nov 9, 2022
|
@oubidar-Abderrahim can you please help us with assigning this PR to the right person? |
|
@fniephaus Could you please help us getting this integrated/reviewed? It's causing integration test failures on our end. |
fniephaus
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest JDK code received an update to bound the
reported container memory above by the total physical memory
of the host running the container. See JDK-8292541
Implement the same in GraalVM, only substituting the class/methods
if they exist in the JDK.
Closes #5387