Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Add support for CgroupMetrics.getTotalMemory0 #470

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Backport: Add support for CgroupMetrics.getTotalMemory0 #470

merged 2 commits into from
Jan 17, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Jan 17, 2023

Backports oracle#5390. The only difference being making interface PhysicalMemorySupport public, which seems fine to me.

When running the reproducer on a patched GraalVM build the JFR warning is gone.

Thoughts?

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2023
@jerboaa jerboaa added backport and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Jan 17, 2023
@jerboaa jerboaa linked an issue Jan 17, 2023 that may be closed by this pull request
[21.3] Backport the ContainerConfiguration JFR fix to 21.3 #469
Closed
@jerboaa jerboaa requested a review from zakkak January 17, 2023 17:09
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2023
zakkak
zakkak approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's rebase it once we bump the version and merge it.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jan 17, 2023

Thanks for the review!

@jerboaa jerboaa force-pushed the fix_container_config_jfr branch from 7f200ee to da7bcb9 Compare January 17, 2023 18:19
@jerboaa
Copy link
Collaborator Author

jerboaa commented Jan 17, 2023

Let's rebase it once we bump the version and merge it.

Rebased.

@zakkak zakkak merged commit 248a2dc into graalvm:mandrel/21.3 Jan 17, 2023
@zakkak zakkak added this to the 21.3.5.1-Final milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
backport OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
21.3.5.1-Final
Development

Successfully merging this pull request may close these issues.

[21.3] Backport the ContainerConfiguration JFR fix to 21.3
2 participants
@jerboaa @zakkak