Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-11098] prep for release #996

Merged
merged 2 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [5.3.5] - Jan 29, 2025

### Bug Fixes
- Rollout experiment key exclusion from activate method([#949](https://github.com/optimizely/javascript-sdk/pull/949))
- Using `optimizely.readyPromise` instead of `optimizely.onReady` to avoid setTimeout call in edge environments. ([#995](https://github.com/optimizely/javascript-sdk/pull/995))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the Rolloup experiment fix here as well


## [5.3.4] - Jun 28, 2024

### Changed
Expand Down
2 changes: 1 addition & 1 deletion lib/index.browser.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe('javascript-sdk (Browser)', function() {
optlyInstance.onReady().catch(function() {});

assert.instanceOf(optlyInstance, Optimizely);
assert.equal(optlyInstance.clientVersion, '5.3.4');
assert.equal(optlyInstance.clientVersion, '5.3.5');
});

it('should set the JavaScript client engine and version', function() {
Expand Down
2 changes: 1 addition & 1 deletion lib/index.lite.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('optimizelyFactory', function() {
optlyInstance.onReady().catch(function() {});

assert.instanceOf(optlyInstance, Optimizely);
assert.equal(optlyInstance.clientVersion, '5.3.4');
assert.equal(optlyInstance.clientVersion, '5.3.5');
});
});
});
Expand Down
2 changes: 1 addition & 1 deletion lib/index.node.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('optimizelyFactory', function() {
optlyInstance.onReady().catch(function() {});

assert.instanceOf(optlyInstance, Optimizely);
assert.equal(optlyInstance.clientVersion, '5.3.4');
assert.equal(optlyInstance.clientVersion, '5.3.5');
});

describe('event processor configuration', function() {
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/enums/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export const NODE_CLIENT_ENGINE = 'node-sdk';
export const REACT_CLIENT_ENGINE = 'react-sdk';
export const REACT_NATIVE_CLIENT_ENGINE = 'react-native-sdk';
export const REACT_NATIVE_JS_CLIENT_ENGINE = 'react-native-js-sdk';
export const CLIENT_VERSION ='5.3.4'
export const CLIENT_VERSION ='5.3.5'

export const DECISION_NOTIFICATION_TYPES = {
AB_TEST: 'ab-test',
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@optimizely/optimizely-sdk",
"version": "5.3.4",
"version": "5.3.5",
"description": "JavaScript SDK for Optimizely Feature Experimentation, Optimizely Full Stack (legacy), and Optimizely Rollouts",
"module": "dist/optimizely.browser.es.js",
"main": "dist/optimizely.node.min.js",
Expand Down
2 changes: 1 addition & 1 deletion tests/index.react_native.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('javascript-sdk/react-native', () => {

expect(optlyInstance).toBeInstanceOf(Optimizely);
// @ts-ignore
expect(optlyInstance.clientVersion).toEqual('5.3.4');
expect(optlyInstance.clientVersion).toEqual('5.3.5');
});

it('should set the React Native JS client engine and javascript SDK version', () => {
Expand Down
Loading