Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-11098] prep for release #996

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Test plan

Existing tests should pass

Issues

@coveralls
Copy link

coveralls commented Jan 29, 2025

Coverage Status

coverage: 90.366%. remained the same
when pulling 5b5eb69 on junaed/prepare-5.3.5
into 617fa35 on 5.x.x.


### Bug Fixes

- Using `optimizely.readyPromise` instead of `optimizely.onReady` to avoid setTimeout call in edge environments. ([#995](https://github.com/optimizely/javascript-sdk/pull/995))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the Rolloup experiment fix here as well

Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one comment

@junaed-optimizely junaed-optimizely merged commit 90ef0d7 into 5.x.x Jan 29, 2025
9 of 11 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/prepare-5.3.5 branch January 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants