Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed Promise Polyfill to reduce bundle size #417

Merged
merged 14 commits into from
Mar 9, 2020
Merged

refactor: Removed Promise Polyfill to reduce bundle size #417

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
82e1db0
removed promise polyfill
zashraf1985 Feb 26, 2020
38f52d7
removed i.e from browserstack list
zashraf1985 Feb 26, 2020
ceab04d
fixed a minor error
zashraf1985 Feb 26, 2020
8385199
removed older browsers which dont support promises
zashraf1985 Feb 26, 2020
93f6227
removed old browsers from base config
zashraf1985 Feb 26, 2020
048c053
Merge branch 'master' into zeeshan/remove-promise-polyfill
zashraf1985 Feb 26, 2020
928f47c
added promise polyfill include in browser umd tests
zashraf1985 Feb 27, 2020
646d0e4
include polyfill in a missing place
zashraf1985 Feb 27, 2020
ae75d51
Merge branch 'master' into zeeshan/remove-promise-polyfill
mjc1283 Feb 28, 2020
51468c9
moved promise polyfill to dev dependencies
zashraf1985 Feb 28, 2020
bad84bf
Merge branch 'master' into zeeshan/remove-promise-polyfill
zashraf1985 Mar 3, 2020
a20a14c
Merge branch 'master' into zeeshan/remove-promise-polyfill
zashraf1985 Mar 4, 2020
e1bb4f9
Merge branch 'master' into zeeshan/remove-promise-polyfill
zashraf1985 Mar 5, 2020
4ad521b
Merge branch 'master' into zeeshan/remove-promise-polyfill
zashraf1985 Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/optimizely-sdk/karma.bs.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module.exports = function(config) {

// list of files / patterns to load in the browser
files: [
'./node_modules/promise-polyfill/dist/polyfill.min.js',
'./lib/index.browser.tests.js'
],
});
Expand Down
1 change: 1 addition & 0 deletions packages/optimizely-sdk/karma.umd.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module.exports = function(config) {

// list of files / patterns to load in the browser
files: [
'./node_modules/promise-polyfill/dist/polyfill.min.js',
'./dist/optimizely.browser.umd.min.js',
'./lib/index.browser.umdtests.js'
],
Expand Down
1 change: 0 additions & 1 deletion packages/optimizely-sdk/lib/index.browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
require('promise-polyfill/dist/polyfill');
var logging = require('@optimizely/js-sdk-logging');
var fns = require('./utils/fns');
var configValidator = require('./utils/config_validator');
Expand Down